----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review89023 -----------------------------------------------------------
applets/icon/plugin/icon_p.cpp (line 203) <https://git.reviewboard.kde.org/r/126149/#comment60948> PreferLocalFile is only good for displaying to the user. Otherwise you have something which is "a path or a URL", and most API doesn't work with that. applets/icon/plugin/icon_p.cpp (line 205) <https://git.reviewboard.kde.org/r/126149/#comment60949> This only works with local files, so it should be in a if (m_url.isLocalFile()) block, and use m_url.toLocalFile(). The current code would break on Windows at least, and possibly in case of filenames with '#'. Put the result of toLocalFile() in a temporary QString, you'll need further down as well. applets/icon/plugin/icon_p.cpp (line 211) <https://git.reviewboard.kde.org/r/126149/#comment60950> Yes, don't ;) Actually this is a local-to-local copy, you could just use QFile::copy if you want it synchronous. applets/icon/plugin/icon_p.cpp (line 239) <https://git.reviewboard.kde.org/r/126149/#comment60951> why commented out? - David Faure On Nov. 26, 2015, 8:15 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126149/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 8:15 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: ? > https://bugs.kde.org/show_bug.cgi?id=? > > > Repository: plasma-workspace > > > Description > ------- > > This brings back the KPropertiesDialog to modify an icon's appearance. This > has been requested at multiple occasions. This has been adapted from the > Plasma 4 icon code. > > > Diffs > ----- > > applets/icon/package/contents/ui/main.qml 9286b94 > applets/icon/plugin/icon_p.h dd7963c > applets/icon/plugin/icon_p.cpp e086870 > > Diff: https://git.reviewboard.kde.org/r/126149/diff/ > > > Testing > ------- > > Dropped a file from my home onto the desktop -> dialog from the actual file, > allowing to rename it. The applet reflected the changes. > > Dropped an application from kickoff to the desktop -> dialog from a copy of > the desktop file, allowing to change its icon and description. The applet > reflected the changes. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
