Re: Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/#review86995 --- This should work, but IMHO it does not go far enough. I can se

Re: Review Request 125681: Correctly set the printSetting's parent

> On Oct. 18, 2015, 1:52 a.m., Michael Pyne wrote: > > I agree that the current code is broken, and that your fix makes sense > > given the surrounding comments clarifying ownership. But why not simply > > construct the print settings object with the dialog as a parent? I see no > > reason the

Re: Review Request 125681: Correctly set the printSetting's parent

> On Oct. 18, 2015, 1:52 a.m., Michael Pyne wrote: > > I agree that the current code is broken, and that your fix makes sense > > given the surrounding comments clarifying ownership. But why not simply > > construct the print settings object with the dialog as a parent? I see no > > reason the

Review Request 125682: Pre-fill translator information for KAboutApplicationDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125682/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and

Re: Review Request 125681: Correctly set the printSetting's parent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125681/#review86991 --- Ship it! I agree that the current code is broken, and that yo

Review Request 125681: Correctly set the printSetting's parent

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125681/ --- Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.

Re: Review Request 125679: Fix setTranslator example code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125679/#review86990 --- Ship it! Ship It! - Michael Pyne On Oct. 17, 2015, 8:58 p.

Review Request 125679: Fix setTranslator example code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125679/ --- Review request for KDE Frameworks and Michael Pyne. Repository: kcoreaddo

Re: Need help with i18n bug: translators' names don't show up in KAboutData

El Saturday 17 October 2015, a les 15:03:14, Michael Pyne va escriure: > Hi all, > > A few of our translators have reported that the list of translators does not > show up in KF5-using applications, because KAboutData::translators(). > Apparently this is because the translation is done using a tra

Need help with i18n bug: translators' names don't show up in KAboutData

Hi all, A few of our translators have reported that the list of translators does not show up in KF5-using applications, because KAboutData::translators(). Apparently this is because the translation is done using a translation context... but kcoreaddons cannot use i18nc as a low-level component,

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/#review86979 --- Used in dolphin: https://git.reviewboard.kde.org/r/125675/ -

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125436/ --- (Updated Okt. 17, 2015, 3:06 nachm.) Review request for Dolphin and KDE F

Re: Review Request 125436: Add an interface which allow plugin to show custom overlay icons (in KIO)

> On Sept. 28, 2015, 6:25 nachm., Sune Vuorela wrote: > > src/widgets/koverlayiconplugin.h, line 55 > > > > > > Is a plugin expected to return multiple overlays, and if so are > > consumers of this interface expe

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

Hi David, 2015-09-28 23:21 GMT+03:00 David Faure : > Naming: "experimental" sounds like "it will be a framework at some point, > when it > stabilizes". Maybe we should say "internal" either, i.e. used internally by > apps > and workspace, don't use outside of that. Which still doesn't prevent a

Review Request 125673: Remove KNotifications dep from KParts

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125673/ --- Review request for KDE Frameworks and David Faure. Repository: kparts D

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/ --- (Updated Oct. 17, 2015, 12:33 p.m.) Status -- This change has been m

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

> On Oct. 17, 2015, 12:23 p.m., David Faure wrote: > > I have no opinion on /kconfig vs /kconfig5. It's internal, we can fix it at > > any time, so whether we change it now, or for kf6, or never... makes no > > difference. I use /kconfig then, and it is not that internal, e.g. as soon as KText

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/#review86960 --- Ship it! I have no opinion on /kconfig vs /kconfig5. It's int

Re: Review Request 125616: Make doctools + wallet optional

> On Oct. 12, 2015, 10:01 p.m., Albert Astals Cid wrote: > > People should known what they are missing when building without the > > dependencies, please specify so at the summary > > Christoph Cullmann wrote: > Yes, that is true, will update the patch tomorrow. > > Christoph Cullmann wrot

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

> On Oct. 17, 2015, 11:22 a.m., David Faure wrote: > > autotests/fallbackconfigresourcestest.cpp, line 32 > > > > > > unused? Fixed ;=) Beside that, ok to go in? Should it be :kconfig5/ or :kconfig/ like asked

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/ --- (Updated Oct. 17, 2015, 12:01 p.m.) Review request for KDE Frameworks and

Re: Review Request 125638: Avoid kio crashs if no dbus server is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125638/ --- (Updated Oct. 17, 2015, 11:58 a.m.) Status -- This change has been m

Re: Review Request 125647: Fix KArchiveTest::testTarCopyTo on NTFS

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125647/ --- (Updated Oct. 17, 2015, 11:55 a.m.) Status -- This change has been m

Re: Review Request 125556: Install CamelCase headers

> On Oct. 11, 2015, 9:03 p.m., David Faure wrote: > > src/CMakeLists.txt, line 24 > > > > > > Well, then the lib itself shouldn't be called KF5MediaWiki? > > > > But of course changing this is only possib

Re: Review Request 125638: Avoid kio crashs if no dbus server is running

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125638/#review86953 --- Ship it! Ship It! - David Faure On Oct. 14, 2015, 5:01 p.m

Re: Review Request 125598: Allow KConfig to use resources as fallback config files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/#review86951 --- autotests/fallbackconfigresourcestest.cpp (line 25)