> On Sept. 28, 2015, 6:25 nachm., Sune Vuorela wrote:
> > src/widgets/koverlayiconplugin.h, line 55
> > <https://git.reviewboard.kde.org/r/125436/diff/2/?file=408602#file408602line55>
> >
> >     Is a plugin expected to return multiple overlays, and if so are 
> > consumers of this interface expected to stack them all together? In what 
> > order?
> >     
> >     How is multiple oevrlay plugins to be handled? all of them stacked 
> > together ? In what order?
> >     
> >     I am wondering if either a QList<QIcon> - or let the plugin do the 
> > squashing - just QIcon - is a better return value.
> >     
> >     the naming "getOverlays" feels a bit java-esque.
> >     oh. and should it be const?

Yes, it can return several icons, and the implementation will display them all 
in every possible corner
or next to eachother.

In particular, owncloud can have the sync status icon and the share status icon)

I made it non const because the implementation will likely make something to 
fetch the icon or cache it which would require to const_cast or use mutable 
everywhere.


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125436/#review86063
-----------------------------------------------------------


On Sept. 28, 2015, 9:14 vorm., Olivier Goffart wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125436/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2015, 9:14 vorm.)
> 
> 
> Review request for Dolphin and KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> The interface from https://git.reviewboard.kde.org/r/125136/ moved into KIO.
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt 820cd34 
>   src/widgets/koverlayiconplugin.cpp PRE-CREATION 
>   src/widgets/koverlayiconplugin.desktop PRE-CREATION 
>   src/widgets/koverlayiconplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125436/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Goffart
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to