----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125673/ -----------------------------------------------------------
Review request for KDE Frameworks and David Faure. Repository: kparts Description ------- KParts uses KNotification to raise some notification for the open or save dialog. Given no other framework beside khtml/plasma uses explicit notifications, I don't see a gain in having this for this one question dialog here, given all other dialogs don't do this in all frameworks. Will avoid one dependency for all thigs using kparts without a loss of functionality. If removing is bad, I can make this optional, but I don't really see the gain in having it. Diffs ----- CMakeLists.txt 6abfd4d src/CMakeLists.txt 530273d src/browseropenorsavequestion.cpp e1a9f45 Diff: https://git.reviewboard.kde.org/r/125673/diff/ Testing ------- Compiled, worked. Thanks, Christoph Cullmann
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
