Re: Review Request 123632: Fix the i18n after Jerome's patch

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/#review79868 --- Sorry, that's not enough you need to add the loader to the sou

Re: Review Request 123632: Fix the i18n after Jerome's patch

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/#review79867 --- Ship it! Ship It! - Albert Astals Cid On mai. 4, 2015, 3:5

Re: Circular dependency in kde-build-metadata

On Monday, May 04, 2015 01:51:52 PM Daniel Vrátil wrote: > Hi, > > commit a5f6c247d99db3a3f565f5fa8d1346420e5a892c ("frameworksintegration > tests want oxygen-fonts") in kde-build-metadata has introduced a circular > dependency between frameworkintegration and oxygen, leading to > > $ kdesrc-bu

Circular dependency in kde-build-metadata

Hi, commit a5f6c247d99db3a3f565f5fa8d1346420e5a892c ("frameworksintegration tests want oxygen-fonts") in kde-build-metadata has introduced a circular dependency between frameworkintegration and oxygen, leading to $ kdesrc-build --refresh-build kf5 plasma5 * Downloading projects.kde.org project

Re: [KDE/Mac] CI for kf5-qt5 is not green anymore

On May 4, 2015, at 2:00 AM, René J.V. Bertin wrote: > On Saturday May 02 2015 09:42:44 Scarlett Clark wrote: >> On Saturday, May 02, 2015 10:20:27 AM David Faure wrote: >>> KMainWindow_UnitTest::testDefaultName() Cannot create window: no screens >>> available >> >> Yes it is a CI issue. We conn

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 4, 2015, 5:44 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123631: Only add a '/' if the url does not end with one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123631/#review79855 --- Ship it! You can differentiate between "smb://" and "smb:" by

Re: Review Request 122680: kglobalaccel: Remove the runtime's KAboutData

> On May 3, 2015, 2:34 p.m., Albert Astals Cid wrote: > > I'm confused, the title say "Remove KAboutData" and then goes and changes > > i18n while breaking it? > > > > I mean i18n handling is relatively easy, and we have pretty good > > documentation at > > https://techbase.kde.org/Developmen

Review Request 123632: Fix the i18n after Jerome's patch

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123632/ --- Review request for KDE Frameworks. Repository: kglobalaccel Description

Re: Review Request 123101: Only add "/" to path if really necessary

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123101/ --- (Updated May 4, 2015, 3:13 p.m.) Status -- This change has been mark

Re: Review Request 123630: Remove unused dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123630/#review79847 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 4, 2015, 4:4

Review Request 123631: Only add a '/' if the url does not end with one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123631/ --- Review request for KDE Frameworks, Àlex Fiestas and David Faure. Reposito

Review Request 123630: Remove unused dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123630/ --- Review request for KDE Frameworks. Repository: kross Description --

Re: Review Request 123570: Add a method to insert new known structures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- (Updated May 4, 2015, 1:25 p.m.) Status -- This change has been mark

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 4, 2015, 1:03 p.m.) Review request for KDE Frameworks and Pl

Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 13:11:05 David Faure wrote: > On Monday 04 May 2015 12:29:39 David Faure wrote: > > On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > > > The issue could be easily fixed by moving the myframework_version.h into > > > $PREFIX/include/KF5/$FRAMEWORK/, no? > > > > Correct, this

Re: Review Request 123528: Add missing license file: COPYING.LGPL-2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123528/#review79838 --- Ship it! Ship It! - Jonathan Riddell On April 27, 2015, 1:

Re: Review Request 123528: Add missing license file: COPYING.LGPL-2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123528/ --- (Updated May 4, 2015, 11:58 a.m.) Status -- This change has been mar

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 12:29:39 David Faure wrote: > On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > > The issue could be easily fixed by moving the myframework_version.h into > > $PREFIX/include/KF5/$FRAMEWORK/, no? > > Correct, this is what KArchive does. Ooops, I thought we were talking abou

Re: Install location of myframework_version.h headers

On Monday 04 May 2015 12:23:32 Kevin Funk wrote: > The issue could be easily fixed by moving the myframework_version.h into > $PREFIX/include/KF5/$FRAMEWORK/, no? Correct, this is what KArchive does. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 __

Re: Install location of myframework_version.h headers

On Monday, May 04, 2015 12:23:32 Kevin Funk wrote: > Heya, > > I'm wondering why, for instance, ktexteditor_version.h is installed to > $PREFIX/include/KF5 instead of $PREFIX/include/KF5/KTextEditor. > > This currently leads to confusing behavior when trying to include this > header if two versio

Install location of myframework_version.h headers

Heya, I'm wondering why, for instance, ktexteditor_version.h is installed to $PREFIX/include/KF5 instead of $PREFIX/include/KF5/KTextEditor. This currently leads to confusing behavior when trying to include this header if two versions of KTextEditor are installed in different locations. Suppos

Re: Review Request 123570: Add a method to insert new known structures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/#review79836 --- Ship it! src/kpackage/packageloader.h (line 85)

Re: [KDE/Mac] CI for kf5-qt5 is not green anymore

On Saturday May 02 2015 09:42:44 Scarlett Clark wrote: >On Saturday, May 02, 2015 10:20:27 AM David Faure wrote: >> KMainWindow_UnitTest::testDefaultName() Cannot create window: no screens >> available > >Yes it is a CI issue. We connect to slaves via SSH and therefore GUI is not >available. I am