----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123631/#review79855 -----------------------------------------------------------
Ship it! You can differentiate between "smb://" and "smb:" by using host().isNull(), but OK, I'm not sure if the result will be more readable (it would be faster though). - David Faure On May 4, 2015, 2:59 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123631/ > ----------------------------------------------------------- > > (Updated May 4, 2015, 2:59 p.m.) > > > Review request for KDE Frameworks, Àlex Fiestas and David Faure. > > > Repository: frameworkintegration > > > Description > ------- > > I could not figure out any other way of knowing if the path ends with '/' > than calling toString so that is what I am doing (can't use QUrl::path() as > it doesn't differentiate between "smb://" and "smb:", they all return an > empty path). > > This patch adds a test with 3 different data that now behave correctly, > before smb: and smb:// were failing. > > (Note: This comes from https://git.reviewboard.kde.org/r/123111/ where it got > a bit stuck. Corrects the issues pointed out by David Faure) > > > Diffs > ----- > > autotests/CMakeLists.txt d110adb > autotests/kdirselectdialog_unittest.cpp PRE-CREATION > src/platformtheme/kdirselectdialog.cpp 9a4082a > src/platformtheme/kdirselectdialog_p.h 8b5c77a > > Diff: https://git.reviewboard.kde.org/r/123631/diff/ > > > Testing > ------- > > Tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
