----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/#review79836 -----------------------------------------------------------
Ship it! src/kpackage/packageloader.h (line 85) <https://git.reviewboard.kde.org/r/123570/#comment54677> suck as -> such as src/kpackage/packageloader.h (line 93) <https://git.reviewboard.kde.org/r/123570/#comment54678> suck as :) Typos in the docs, otherwise +2. - Sebastian Kügler On April 30, 2015, 9:31 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123570/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 9:31 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kpackage > > > Description > ------- > > When we have internal structures that aren't plugins, > loadpackage/listPackages/findPackages are pretty much broken, since they > can't find the structure instance. > > in order to load packages one can subclass packageloader, but listing still > doesn't work. > this makes possible for apps to insert new structure types without having to > subclass. > an alternative is an internalListPackages similar to internalLoadPackage, but > i'm not too keep to use a packageloader subclass in libplasma, because then > any user of libplasma could replace the packageloader again, breaking it. > > or alternatively all internal plasma package types could become plugins as > well (that i fear would become necessary at some point if we want to be able > to fully replace plasmapkg2 with kpackagetool) > > > Diffs > ----- > > src/kpackage/packageloader.h 4cc40e6 > src/kpackage/packageloader.cpp 174f54b > > Diff: https://git.reviewboard.kde.org/r/123570/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
