----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ -----------------------------------------------------------
(Updated May 4, 2015, 1:25 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Changes ------- Submitted with commit 92c9da3e0ce4f4131c629e14dfdbb3fca7546e0d by Marco Martin to branch master. Repository: kpackage Description ------- When we have internal structures that aren't plugins, loadpackage/listPackages/findPackages are pretty much broken, since they can't find the structure instance. in order to load packages one can subclass packageloader, but listing still doesn't work. this makes possible for apps to insert new structure types without having to subclass. an alternative is an internalListPackages similar to internalLoadPackage, but i'm not too keep to use a packageloader subclass in libplasma, because then any user of libplasma could replace the packageloader again, breaking it. or alternatively all internal plasma package types could become plugins as well (that i fear would become necessary at some point if we want to be able to fully replace plasmapkg2 with kpackagetool) Diffs ----- src/kpackage/packageloader.h 4cc40e6 src/kpackage/packageloader.cpp 174f54b Diff: https://git.reviewboard.kde.org/r/123570/diff/ Testing ------- Thanks, Marco Martin
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
