Re: KDE Frameworks 5.2.0 release

2014-09-11 Thread Marko Käning
Hi, herewith I can verify that all frameworks at their current head versions build just fine with the latest cmake release 3.0.2 (on OSX). I report this since there have been serious issues during the last weeks with some git versions of cmake - on OSX at least (see thread [1] for details). Gr

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
> On Sept. 11, 2014, 10:19 p.m., Aleix Pol Gonzalez wrote: > > Why is the component responsible for defining how it's going to be visually > > integrated with the host application? > > > > Do we get to hit the scrollbar if the component doesn't have a margin and > > it's by the screen's border

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Ben Cooksley
> On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: > > What is the status of this? Is there anything blocking it being shipped and > > made available on api.kde.org? > > Denis Steckelmacher wrote: > It works locally, so I'm just waiting for a ship-it or other comments :-) > > Aleix Pol Go

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Matthew Dawson
> On Sept. 8, 2014, 6:22 p.m., Ben Cooksley wrote: > > What is the status of this? Is there anything blocking it being shipped and > > made available on api.kde.org? > > Denis Steckelmacher wrote: > It works locally, so I'm just waiting for a ship-it or other comments :-) > > Aleix Pol Gon

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119991/#review66315 --- Ship it! Ship It! - Matthew Dawson On Aug. 29, 2014, 10:16

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Ben Cooksley
> On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: > > What is the status of this? Is there anything blocking it being shipped and > > made available on api.kde.org? > > Denis Steckelmacher wrote: > It works locally, so I'm just waiting for a ship-it or other comments :-) > > Aleix Pol Go

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-11 Thread Matthew Dawson
> On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used outside of KConfig, I'd prefer if > > KConfigBase

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-11 Thread Matthew Dawson
> On Sept. 8, 2014, 6:22 p.m., Ben Cooksley wrote: > > What is the status of this? Is there anything blocking it being shipped and > > made available on api.kde.org? > > Denis Steckelmacher wrote: > It works locally, so I'm just waiting for a ship-it or other comments :-) > > Aleix Pol Gon

Re: Review Request 120144: Equal entries imply existing

2014-09-11 Thread Jan-Marek Glogowski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120144/ --- (Updated Sept. 12, 2014, 1:07 a.m.) Status -- This change has been m

Re: Review Request 120144: Equal entries imply existing

2014-09-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120144/#review66307 --- Ship it! Makes a lot of sense. I guess "identical files" was

Re: [dot] KDE Frameworks 5.2.0 release

2014-09-11 Thread David Faure
On Thursday 11 September 2014 22:13:49 Jonathan Riddell wrote: > On Thu, Sep 11, 2014 at 11:00:15PM +0200, David Faure wrote: > > E.g. can someone write info/kde-frameworks-5.2.0.php > > based on the input I gave, or shall I do my own thing there as fallback > > (won't be as good but better than no

Re: Kioslave repos

2014-09-11 Thread David Faure
On Wednesday 20 August 2014 11:38:12 Jonathan Riddell wrote: > On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: > >On Tue, Aug 19, 2014 at 9:49 PM, David Faure wrote: > > On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: > > > On Tue, Jul 01, 2014 at 11:25:11PM +0200

[kdesrc-build] /: Remove cmake-git, by popular demand.

2014-09-11 Thread David Faure
Git commit f900be278e4e90d4df64b8393114dbbceebc2a53 by David Faure. Committed on 11/09/2014 at 23:53. Pushed by dfaure into branch 'master'. Remove cmake-git, by popular demand. Most people no longer need to build their own cmake, most distros ship a recent enough one. If you still want your ow

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/#review66298 --- Why is the component responsible for defining how it's going t

Jenkins build is back to stable : ktexteditor_master_qt5 #648

2014-09-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #646

2014-09-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/ --- (Updated Sept. 11, 2014, 9:25 p.m.) Status -- This change has been m

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
> On Sept. 11, 2014, 7:39 p.m., Dominik Haumann wrote: > > src/view/kateview.cpp, line 373 > > > > > > this should be "right spacer", right? :-) All fixed. Will push. Thanks for the review. Don't hesitate to pin

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/ --- (Updated Sept. 11, 2014, 9:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

2014-09-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120138/#review66289 --- autotests/kurifiltertest.cpp

Re: [dot] KDE Frameworks 5.2.0 release

2014-09-11 Thread Jonathan Riddell
On Thu, Sep 11, 2014 at 11:00:15PM +0200, David Faure wrote: > E.g. can someone write info/kde-frameworks-5.2.0.php > based on the input I gave, or shall I do my own thing there as fallback > (won't > be as good but better than nothing) ? There's no changing content here, should be just a copy a

Re: KDE Frameworks 5.2.0 release

2014-09-11 Thread Marko Käning
Hi David, On 11 Sep 2014, at 22:39 , David Faure wrote: > OK, so for the release notes, > "now builds on OSX" :-) please, skip the “now” since it is building fine for frameworks already since KF 5.0.0 [1]. :-) Greets, Marko [1] https://projects.kde.org/news/271 P.S.: I’ll try installing

Re: [dot] KDE Frameworks 5.2.0 release

2014-09-11 Thread David Faure
On Thursday 11 September 2014 12:10:39 Carl Symons wrote: > Your response made me think of this in more depth. I think that your > take on it is correct. The announcements about the frequent releases > should be tailored to developers. > > Jos has been pushing promotion of Frameworks 5 and the K

Re: KDE Frameworks 5.2.0 release

2014-09-11 Thread David Faure
On Thursday 11 September 2014 20:50:15 Marko Käning wrote: > Hi David, > > On 11 Sep 2014, at 18:55 , David Faure wrote: > > On Wednesday 10 September 2014 21:13:10 Marko Käning wrote: > >> considering the upcoming 5.2.0 release I just wanted to inform you, > >> that there are currently no issues

Problem with list_dependencies tool when asking for project dependency information

2014-09-11 Thread Marko Käning
Hi, quite a few times I was hit by the fact that the list_dependencies tool returns something seemingly valid, even if the project specified doesn’t exist like here: --- $ ./list_dependencies kdesupport/prison kdesupport/extra-cmake-modules Qt5[stable] kdesupport/prison $ ./list_dependencies kde

Jenkins build is back to stable : ktexteditor_master_qt5 #641

2014-09-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/#review66286 --- Ship it! The patch looks good. Please commit. If we find regr

Re: [dot] KDE Frameworks 5.2.0 release

2014-09-11 Thread Carl Symons
On 09/10/2014 02:05 AM, David Faure wrote: On Tuesday 09 September 2014 08:21:02 Carl Symons wrote: On 09/09/2014 06:57 AM, David Faure wrote: I just tagged and packed 5.2.0. I extracted the following changelog items from git commits. But I don't really understand the plasma-framework and th

Re: KDE Frameworks 5.2.0 release

2014-09-11 Thread Marko Käning
Hi David, On 11 Sep 2014, at 18:55 , David Faure wrote: > On Wednesday 10 September 2014 21:13:10 Marko Käning wrote: >> considering the upcoming 5.2.0 release I just wanted to inform you, >> that there are currently no issues with any framework on OSX/CI. :) > Thanks Marko, that's a very importa

Re: Review Request 119867: Fix CustomStyleElement

2014-09-11 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/ --- (Updated Sept. 11, 2014, 5:29 p.m.) Status -- This change has been m

Re: KDE Frameworks 5.2.0 release

2014-09-11 Thread David Faure
On Wednesday 10 September 2014 21:13:10 Marko Käning wrote: > Hi David, > > considering the upcoming 5.2.0 release I just wanted to inform you, > that there are currently no issues with any framework on OSX/CI. :) Thanks Marko, that's a very important item to add to the release notes: "now work

Re: Review Request 120131: Fix encoding issue in places dialog.

2014-09-11 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120131/ --- (Updated Sept. 11, 2014, 4:11 p.m.) Status -- This change has been m

Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-11 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120147/ --- Review request for KDE Frameworks and Christoph Cullmann. Bugs: 158379

Re: There's no proper replacement for KIcon

2014-09-11 Thread Eike Hein
On 11.09.2014 17:22, Kevin Krammer wrote: Or do you mean install the custom theme twice, once as itself and once as hicolor? Wait - I think I now understand why we're having trouble communicating about this. You think a distro has the option to install Oxygen *as* hicolor, right, making my p

Re: There's no proper replacement for KIcon

2014-09-11 Thread Eike Hein
On 11.09.2014 17:22, Kevin Krammer wrote: Hicolor is there for cases where the setup fails to provide any workspace or distribution specific theme. Yes. So I'm thinking ahead and telling you how that "setup" looks like for a workspace: - Write a Qt platform plugin. Needs coding chops. We hav

Re: Review Request 119867: Fix CustomStyleElement

2014-09-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/#review66279 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Aug. 22

Re: Review Request 119867: Fix CustomStyleElement

2014-09-11 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119867/#review66277 --- ping ? - Hugo Pereira Da Costa On Aug. 22, 2014, 11:27 a.m.

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 17:05:43, Eike Hein wrote: > On 11.09.2014 16:09, Kevin Krammer wrote: > > Why would hicolor be distro/ISV specific? > > Because a hicolor theme everyone likes visually isn't going > to happen. People will want to modify what's in that fall- > back for theming reasons, and

Review Request 120144: Equal entries imply existing

2014-09-11 Thread Jan-Marek Glogowski
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120144/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: There's no proper replacement for KIcon

2014-09-11 Thread Eike Hein
On 11.09.2014 16:09, Kevin Krammer wrote: Why would hicolor be distro/ISV specific? Because a hicolor theme everyone likes visually isn't going to happen. People will want to modify what's in that fall- back for theming reasons, and distros theme to differentiate themselves. In the "hicolor

Re: Review Request 120142: correct documentation for overlays parameter

2014-09-11 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120142/#review66270 --- Ship it! Ship It! - Christoph Feck On Sept. 11, 2014, 2:02

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 15:53:57, Eike Hein wrote: > On 11.09.2014 15:43, Kevin Krammer wrote: > > Having a configurable fallback before the final fallback can't hurt, but > > that doesn't solve the actual problem of hicolor being incomplete. > > It is just a work around. > > Sort of, except I th

Review Request 120142: correct documentation for overlays parameter

2014-09-11 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120142/ --- Review request for KDE Frameworks. Repository: kiconthemes Description

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-11 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120132/ --- (Updated Sept. 11, 2014, 2:03 p.m.) Status -- This change has been d

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-11 Thread Stefan Brüns
> On Sept. 10, 2014, 9:31 p.m., Luigi Toscano wrote: > > I guess this is about frameworks branch. If yes, please ignore it, as it > > has been split into the several framework repositories; check if the issue > > applies in the separate KIconThemes framework. > > Stefan Brüns wrote: > patc

Re: There's no proper replacement for KIcon

2014-09-11 Thread Eike Hein
On 11.09.2014 15:43, Kevin Krammer wrote: Having a configurable fallback before the final fallback can't hurt, but that doesn't solve the actual problem of hicolor being incomplete. It is just a work around. Sort of, except I think the outcome is more or less the same - either a distro/ISV de

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 15:40:14, Eike Hein wrote: > On 11.09.2014 15:33, Kevin Krammer wrote: > > Sounds interesting, but "checkout" where? > > In this thread, where I've posted it and encouraged reading > it a few times :). Ah :) I thought you were referring to some XDG discussion. Having a c

Re: There's no proper replacement for KIcon

2014-09-11 Thread Eike Hein
On 11.09.2014 15:33, Kevin Krammer wrote: Sounds interesting, but "checkout" where? In this thread, where I've posted it and encouraged reading it a few times :). Cheers, Kevin Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-d

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 15:29:13, Eike Hein wrote: > On 11.09.2014 11:11, Kevin Krammer wrote: > > From my point of view there is little use case of having a fallback if it > > does> > > not allow one to fall back to it. > > Check out the chat log for the idea of enhancing the spec to > add so

Re: There's no proper replacement for KIcon

2014-09-11 Thread Eike Hein
On 11.09.2014 11:11, Kevin Krammer wrote: From my point of view there is little use case of having a fallback if it does not allow one to fall back to it. Check out the chat log for the idea of enhancing the spec to add some sort of system-level configuration scheme to set a fallback one lev

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #109

2014-09-11 Thread KDE CI System
See Changes: [emmanuelpescosta099] fixed TODO: -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in wor

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-09-11 Thread Martin Klapetek
> On Aug. 31, 2014, 6:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used outside of KConfig, I'd prefer if > > KConfigBase

Re: Review Request 119274: Use Atlas textures in SvgItem

2014-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119274/ --- (Updated Sept. 11, 2014, 11:45 a.m.) Status -- This change has been

Review Request 120139: kill warning

2014-09-11 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120139/ --- Review request for KDE Frameworks, Andreas Hartmetz and Stephen Kelly. Re

Problem with kdeinit and StartupInfo

2014-09-11 Thread Christoph Cullmann
Hi, for Kate, the startup info doesn't work atm in frameworks. If you launch dolphin KF5 version and open one file => fine, second file => dolphin blocks and startup info doesn't happen. If you look at the logs, you see: (1975)/(default) KXMessages::broadcastMessageX: KXMessages used on non-X1

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 02:06:02, Albert Astals Cid wrote: > El Dijous, 11 de setembre de 2014, a les 10:57:17, Kevin Krammer va escriure: > > On Thursday, 2014-09-11, 09:33:23, Albert Astals Cid wrote: > > > El Dijous, 11 de setembre de 2014, a les 08:46:11, Kevin Krammer va > > > > escriure: >

Re: There's no proper replacement for KIcon

2014-09-11 Thread Albert Astals Cid
El Dijous, 11 de setembre de 2014, a les 10:57:17, Kevin Krammer va escriure: > On Thursday, 2014-09-11, 09:33:23, Albert Astals Cid wrote: > > El Dijous, 11 de setembre de 2014, a les 08:46:11, Kevin Krammer va > > escriure: > > > The rule to always also install an application icon into Hicolor w

Re: Review Request 120118: Make code coverage possible in any KDE project

2014-09-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120118/ --- (Updated Sept. 11, 2014, 9:05 a.m.) Status -- This change has been m

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #108

2014-09-11 Thread KDE CI System
See Changes: [frank78ac] Make it possible to open archives via the command line -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave

Re: There's no proper replacement for KIcon

2014-09-11 Thread Kevin Krammer
On Thursday, 2014-09-11, 09:33:23, Albert Astals Cid wrote: > El Dijous, 11 de setembre de 2014, a les 08:46:11, Kevin Krammer va escriure: > > The rule to always also install an application icon into Hicolor was meant > > as an example of a general intent that Hicolor be fully usable. > > > > I

Review Request 120138: kshorturifilter : Treat "///..." as "/"

2014-09-11 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120138/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 120118: Make code coverage possible in any KDE project

2014-09-11 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120118/#review66210 --- Ship it! Looks good to me! - Albert Astals Cid On set. 10,

Re: OSX/CI: bovo fails to build on branch frameworks

2014-09-11 Thread Albert Astals Cid
El Dimecres, 10 de setembre de 2014, a les 08:40:13, Treeve Jelbert va escriure: > On Wednesday 10 September 2014 00:10:22 Marko Käning wrote: > > I actually encountered these on linux. > > I have some local patches, which are attached, which fix the problem for me. > > I do do not have commit

Re: There's no proper replacement for KIcon

2014-09-11 Thread Albert Astals Cid
El Dijous, 11 de setembre de 2014, a les 08:46:11, Kevin Krammer va escriure: > On Wednesday, 2014-09-10, 23:43:15, Albert Astals Cid wrote: > > El Dimarts, 9 de setembre de 2014, a les 16:25:26, Kevin Krammer va > > escriure: > > > On Sunday, 2014-09-07, 10:27:06, Albert Astals Cid wrote: > > > >

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-11 Thread Luigi Toscano
> On Set. 10, 2014, 11:31 p.m., Luigi Toscano wrote: > > I guess this is about frameworks branch. If yes, please ignore it, as it > > has been split into the several framework repositories; check if the issue > > applies in the separate KIconThemes framework. > > Stefan Brüns wrote: > patc