-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120118/#review66210
-----------------------------------------------------------

Ship it!


Looks good to me!

- Albert Astals Cid


On set. 10, 2014, 11:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120118/
> -----------------------------------------------------------
> 
> (Updated set. 10, 2014, 11:33 p.m.)
> 
> 
> Review request for Build System and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Introduces a BUILD_COVERAGE option in the KDECompilerSettings file so that we 
> can easily enable it from the jenkins installations, and in case somebody 
> wants to do it locally, then too.
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDECompilerSettings.cmake f0d1aef 
>   modules/ECMCoverageOption.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120118/diff/
> 
> 
> Testing
> -------
> 
> Plasma Framework is already doing it, I just moved the code.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to