> On Sept. 10, 2014, 9:31 p.m., Luigi Toscano wrote: > > I guess this is about frameworks branch. If yes, please ignore it, as it > > has been split into the several framework repositories; check if the issue > > applies in the separate KIconThemes framework. > > Stefan Brüns wrote: > patch applies also to kiconthemes framework > > Luigi Toscano wrote: > So please open a review for kiconthemes and discard this one, because the > frameworks branch of kdelibs is not developed anymore (of course!) after the > split. It is needed to allow proper history through git grafting.
https://git.reviewboard.kde.org/r/120142/ - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120132/#review66195 ----------------------------------------------------------- On Sept. 10, 2014, 9:24 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120132/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2014, 9:24 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > The current documentation is incorrect, as no 'emblem' prefix is added > to the overlay name. Also there is no mention how the emblems are placed. > Instead of giving a complete definition, reference the drawOverlays > method. > > Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de > > > Diffs > ----- > > tier3/kiconthemes/src/kiconloader.h > a32734564786ab1bd7920ce13339f7f8713d9260 > > Diff: https://git.reviewboard.kde.org/r/120132/diff/ > > > Testing > ------- > > > Thanks, > > Stefan Brüns > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
