libkomparediff2

Hello, I've prepared a port of libkomparediff2 to KDE Frameworks and Qt 5.2 on the frameworks branch of it's git repo. If someone would take a look and check if I did anything wrong that would be great. It builds here and the tests all pass, but a second (or more) set of eyes is always welcome.

Review Request 117781: Install again the content of common/, prepare for other languages too

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117781/ --- Review request for Documentation and KDE Frameworks. Repository: kdoctool

Re: plasma-framework in kdereview

Hello, On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: > El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: > > since it was done earlier this week, better announce it formally, so > > everybody can actually do the -review part ;) > > Had a look and i18n wise

Re: plasma-framework in kdereview

El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: > Hi all, > since it was done earlier this week, better announce it formally, so > everybody can actually do the -review part ;) Had a look and i18n wise it looks ok-ish (i.e it's kind of as broken as the rest of framewor

Re: Review Request 117780: Add a FindKF5.cmake module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/#review56584 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 11:14

Re: docbook issues in workspace repos

On Fri, Apr 18, 2014 at 8:27 PM, Burkhard Lück wrote: > Am Freitag, 18. April 2014, 16:54:58 schrieb Burkhard Lück: > > Am Donnerstag, 17. April 2014, 17:42:25 schrieb Aleix Pol: > > > On Mon, Apr 14, 2014 at 12:57 PM, Burkhard Lück > wrote: > > > > Hi, > > > > > > > > I found a lot of docbook i

Re: docbook issues in workspace repos

On Fri, Apr 18, 2014 at 4:54 PM, Burkhard Lück wrote: > Am Donnerstag, 17. April 2014, 17:42:25 schrieb Aleix Pol: > > On Mon, Apr 14, 2014 at 12:57 PM, Burkhard Lück > wrote: > > > Hi, > > > > > > I found a lot of docbook issues in many workspace repos, i. e. code > but no > > > corresponding d

Review Request 117780: Add a FindKF5.cmake module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117780/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 117777: Make the KSelectionProxyModel unit test pass

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmod

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #48

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117733: Fully port KXMessages to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/#review56554 --- This review has been submitted with commit eea0539f480de356ed

Re: Review Request 117733: Fully port KXMessages to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/ --- (Updated April 25, 2014, 5:32 p.m.) Status -- This change has been m

Re: plasma-framework in kdereview

On Friday 25 April 2014 15:14:46 Àlex Fiestas wrote: > On Friday 25 April 2014 12:34:32 Marco Martin wrote: > > Hi all, > > since it was done earlier this week, better announce it formally, so > > everybody can actually do the -review part ;) > > > > the plasma-framework repository has been moved

Re: Review Request 117602: Remove more UPnP stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/ --- (Updated April 25, 2014, 3:03 p.m.) Status -- This change has been m

Re: Review Request 117602: Remove more UPnP stuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117602/#review56538 --- This review has been submitted with commit ff9ff7fffb4cb976cc

Re: plasma-framework in kdereview

On Friday 25 of April 2014 15:43:39 Marco Martin wrote: > On Friday 25 April 2014 15:24:50 Luigi Toscano wrote: > > On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: > > > Moving plasma-framework to frameworks means that we will loose > > > flexibility > > > since we won't be able to break ap

Re: plasma-framework in kdereview

On Friday 25 April 2014 15:24:50 Luigi Toscano wrote: > On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: > > Moving plasma-framework to frameworks means that we will loose flexibility > > since we won't be able to break api/abi. > > > > So, do we really have to move it there? Imho would be

Re: plasma-framework in kdereview

On Friday 25 April 2014 15:14:46 you wrote: > > * there was the plasma shell: has been removed and moved to > > plasma-workspace, decreasing dependencies > > Moving plasma-framework to frameworks means that we will loose flexibility > since we won't be able to break api/abi. that's exactly why i

Re: plasma-framework in kdereview

On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: > Moving plasma-framework to frameworks means that we will loose flexibility > since we won't be able to break api/abi. > > So, do we really have to move it there? Imho would be prudent to keep it > somewhere else where api/abi stability is n

Re: plasma-framework in kdereview

On Friday 25 April 2014 12:34:32 Marco Martin wrote: > Hi all, > since it was done earlier this week, better announce it formally, so > everybody can actually do the -review part ;) > > the plasma-framework repository has been moved in kdereview, headed > hopefully in frameworks. > what it contain

attica and kactivities have moved

... to frameworks. Remember to rm -rf kdesupport/attica kde/kdelibs/kactivities if you're using kdesrc-build, since it will now check them out under frameworks (whichever branch you are building!) BTW, I still don't have a maintainer written down for Attica. In fact it's completely missing from

Jenkins build is back to normal : kdeclarative_master_qt5 #57

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdeclarative_master_qt5 #56

See Changes: [agateau] Define TRANSLATION_DOMAIN -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace

plasma-framework in kdereview

Hi all, since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) the plasma-framework repository has been moved in kdereview, headed hopefully in frameworks. what it contains: * libplasma: it's the old plasma library that used to be in k

Re: Review Request 117708: move kioslave docs paths for co-installability

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117708/#review56509 --- Ship it! Ship It! - Kevin Ottens On April 23, 2014, 3:24 p

Build failed in Jenkins: kross_master_qt5 #42

See Changes: [agateau] Define TRANSLATION_DOMAIN -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: Review Request 117733: Fully port KXMessages to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/#review56508 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 6:58 a

Build failed in Jenkins: kwallet_master_qt5 #92

See -- Started by user alexmerry Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kwallet_master_qt5] $ /bin/sh

Re: Review Request 117581: Remove ECMDBusAddActivationService module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/#review56505 --- This review has been submitted with commit 0fd08930a4f70a0a69

Re: Review Request 117581: Remove ECMDBusAddActivationService module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ --- (Updated April 25, 2014, 10:09 a.m.) Status -- This change has been

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/ --- (Updated April 25, 2014, 10:03 a.m.) Status -- This change has been

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/#review56503 --- This review has been submitted with commit 9e9982ad008596916f

Re: Review Request 117475: kmimeassociationstest: do not use KDE apps in test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117475/#review56501 --- Ship it! Ship It! - David Faure On April 24, 2014, 6:54 p.

Re: Review Request 117581: Remove ECMDBusAddActivationService module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ --- (Updated April 25, 2014, 9:56 a.m.) Review request for Build System, Extr

Re: Review Request 117658: Add a stub for ECMFindModuleHelpers to the find-modules dir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117658/ --- (Updated April 25, 2014, 9:53 a.m.) Status -- This change has been m

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/ --- (Updated April 25, 2014, 9:52 a.m.) Status -- This change has been m

Re: Review Request 117749: Allow kmimeassociationstest to be run alone

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117749/#review56500 --- This review has been submitted with commit d561cad02d33cdab19

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/#review56499 --- This review has been submitted with commit 5e67e4c6c112fce2c9

Re: Review Request 117758: Update install-compile.docbook translations to not reference KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117758/ --- (Updated April 25, 2014, 9:49 a.m.) Status -- This change has been m

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/ --- (Updated April 25, 2014, 9:41 a.m.) Status -- This change has been m

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56498 --- This review has been submitted with commit 035c6fa9390ecb6642

Re: Review Request 117617: New syntax for ecm_install_icons()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/ --- (Updated April 25, 2014, 9:39 a.m.) Status -- This change has been m

Re: Review Request 117617: New syntax for ecm_install_icons()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117617/#review56497 --- This review has been submitted with commit 50b164a7ce83cdaec1

Re: Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117593/ --- (Updated April 25, 2014, 9:36 a.m.) Status -- This change has been m

Re: Review Request 117593: ECMGeneratePriFile: Allow lib and include install dirs to be overridden

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117593/#review56495 --- This review has been submitted with commit 23829defe0455cf575

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 25, 2014, 9:34 a.m.) Status -- This change has been m

Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review56494 --- This review has been submitted with commit 7a829e7e270c8f3bde

Re: Review Request 117585: ECMFindModuleHelpers: set traditional variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/ --- (Updated April 25, 2014, 9:32 a.m.) Status -- This change has been m

Re: Review Request 117585: ECMFindModuleHelpers: set traditional variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117585/#review56493 --- This review has been submitted with commit 283aeda90db966de58

Re: Review Request 117583: Remove use of ecm_dbus_add_activation_service()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117583/#review56492 --- This review has been submitted with commit 1ee89d48fe8338b21d

Re: Review Request 117583: Remove use of ecm_dbus_add_activation_service()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117583/ --- (Updated April 25, 2014, 9:30 a.m.) Status -- This change has been m

Re: Review Request 117706: remove unused kwallet upgrade script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/#review56491 --- This review has been submitted with commit 8455b3600a4651f848

Re: Review Request 117706: remove unused kwallet upgrade script

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117706/ --- (Updated April 25, 2014, 9:28 a.m.) Status -- This change has been m

Re: Android integration in KConfig framework

Hi, thanks for the answer (i'm not in the list :)). I'll try it as soon as I can (hopefully this week-end) and I'll tell you the results. Have a nice day, Johnny 2014-04-24 23:59 GMT+02:00 Aleix Pol : > On Thu, Apr 24, 2014 at 10:55 PM, Aleix Pol wrote: > >> On Thu, Apr 24, 2014 at 9:11 PM,

Re: Review Request 117733: Fully port KXMessages to XCB

> On April 25, 2014, 9:07 a.m., David Faure wrote: > > BTW I'm curious, is this used for something else than startup notification? KWin also uses KXMessages in combination with kstart - Martin --- This is an automatically generated e-ma

Re: Review Request 117733: Fully port KXMessages to XCB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117733/#review56471 --- Ship it! BTW I'm curious, is this used for something else tha

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #47

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117703: Use NETWinInfo instead of custom XLib code in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117703/ --- (Updated April 25, 2014, 7:02 a.m.) Status -- This change has been m

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/#review56470 --- This review has been submitted with commit ba3fe29fe342d20caf

Re: Review Request 117704: Deprecate obsolete KStartupInfo ctor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117704/ --- (Updated April 25, 2014, 7:02 a.m.) Status -- This change has been m

Re: Review Request 117701: Fix crashers in KStartupInfo on remove while iterating

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117701/ --- (Updated April 25, 2014, 7:03 a.m.) Status -- This change has been m

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/#review56468 --- This review has been submitted with commit 3ebc08046491d4df7c

Re: Review Request 117703: Use NETWinInfo instead of custom XLib code in KStartupInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117703/#review56469 --- This review has been submitted with commit 328fe0017472cb6000

Re: Review Request 117704: Deprecate obsolete KStartupInfo ctor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117704/#review56467 --- This review has been submitted with commit 54460f3103c8f94bbe

Re: Review Request 117731: Improve KStartupInfo::Private::remove_startup_info_internal

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117731/ --- (Updated April 25, 2014, 7:02 a.m.) Status -- This change has been m