----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117593/#review56495 -----------------------------------------------------------
This review has been submitted with commit 23829defe0455cf57518ee29fee2988054ed51b7 by Alex Merry to branch master. - Commit Hook On April 16, 2014, 1:35 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117593/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 1:35 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > David Faure. > > > Repository: extra-cmake-modules > > > Description > ------- > > ECMGeneratePriFile: Allow lib and include install dirs to be overridden > > Rather than blindly using ${LIB_INSTALL_DIR} and ${INCLUDE_INSTALL_DIR} > (which assume the inclusion of KDEInstallDirs), this checks whether they > exist, also checks for ${CMAKE_INSTALL_LIBDIR} and > ${CMAKE_INSTALL_INCLUDEDIR} (set by GNUInstallDirs), provides hard-coded > defaults and allows arguments to be used to override the values. > > This should make it useful to projects that aren't KDE Frameworks. > > > Diffs > ----- > > modules/ECMGeneratePriFile.cmake bff2961f9a5fe72c84dff4d0ea4466c7693fe00c > > Diff: https://git.reviewboard.kde.org/r/117593/diff/ > > > Testing > ------- > > Configured, built and installed KArchive. Visually inspected installed .pri > file. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
