----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117777/ -----------------------------------------------------------
Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description ------- Make the KSelectionProxyModel unit test pass It looks like Qt4 emitted layoutChanged in circumstances where Qt5 emits rowsMoved. This could be used to optimize things, but for now we just act the same way in either case (rebuilding the mapping). Add a pedantic mode to modeltest. Cherry-pick of ffd732966d1f2c632d811e8fc378a95aa1456703 This was lost when I updated ModelTest to Qt5. Re-apply Stephen Kelly's modeltest fixes These were lost when I replaced ModelTest with the version from Qt 5. Diffs ----- autotests/CMakeLists.txt 4281fec2de1124162af623cf999db73eff705684 autotests/proxymodeltestsuite/modeltest.h 4b80850d51ca068fb8ffb0a704a9f938b4dacfa9 autotests/proxymodeltestsuite/modeltest.cpp 0928a3a4d78d10fcae4a5671e91e836e9fde429b src/kselectionproxymodel.cpp ea97f7a197f9181745f2979c2f7b2e5e1f0015f3 Diff: https://git.reviewboard.kde.org/r/117777/diff/ Testing ------- Unit tests now pass. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
