----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ -----------------------------------------------------------
(Updated April 25, 2014, 9:34 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne. Repository: kcoreaddons Description ------- Deprecate the catalog name stuff from KAboutData This is pretty useless - the translation catalog has to be set before KAboutData is constructed in order to translate its arguments. Note that we cannot provide a constructor overload that is identical other than omitting the catalog name argument, as that would be ambiguous (if 4 strings are passed, it could be either the new constructor or the old one). So instead, we provide two new constructors: one requiring at least 4 strings and the license type, and one only taking 3 strings. Diffs ----- autotests/kaboutdatatest.cpp 22b013c0626ebea94f371474048c670b3d50dad6 src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing ------- Builds, tests pass. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
