Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #212

2014-03-28 Thread KDE CI System
See Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by upstream project "plasma-framework_master_qt5" build number 212 originall

Re: Moving KPlugionLoader|Factory to KCoreAddons?

2014-03-28 Thread David Faure
On Saturday 29 March 2014 00:38:36 Alex Merry wrote: > While doing work on KService, I realised that KPluginLoader, > KPluginFactory and KExportPlugin could all quite happily go in > KCoreAddons, and it would be really nice to have them there > (KPluginTrader would stay in KService, of course). >

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 117154: Simplify the plugin lookup code

2014-03-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117154/#review54520 --- This patch is mostly about windows stuff, AFAIU. A. Richardso

Jenkins build is back to stable : kemoticons_master_qt5 #34

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117154: Simplify the plugin lookup code

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117154/ --- Review request for KDE Frameworks, kdewin and David Faure. Repository: ks

Moving KPlugionLoader|Factory to KCoreAddons?

2014-03-28 Thread Alex Merry
While doing work on KService, I realised that KPluginLoader, KPluginFactory and KExportPlugin could all quite happily go in KCoreAddons, and it would be really nice to have them there (KPluginTrader would stay in KService, of course). I'm not sure of the BCness or SCness of this, though. I think

Re: Regarding entry.desktop files

2014-03-28 Thread Aleix Pol
On Fri, Mar 28, 2014 at 10:08 PM, Chusslove Illich wrote: > There are now several review requests, in which there is some confusion > about what to do/not to do with entry.desktop files in KF5. There are two > kinds of these files. > > One set of entry.desktop files are those in kde-runtime. They

Re: Move KDED out of frameworks?

2014-03-28 Thread Aleix Pol
On Fri, Mar 28, 2014 at 9:14 PM, Kevin Krammer wrote: > On Friday, 2014-03-28, 20:55:02, Boudewijn Rempt wrote: > > On Fri, 28 Mar 2014, Kevin Krammer wrote: > > > The D-Bus session/user daemon is also something that needs to be > treated > > > in a platform specific way as a dependency. > > > E.

Re: Review Request 117134: Use QLocale to list all languages

2014-03-28 Thread Aleix Pol Gonzalez
> On March 28, 2014, 3:51 p.m., David Faure wrote: > > Same problem as https://git.reviewboard.kde.org/r/117132/ : > > this code is supposed to list the available translations. The new code > > doesn't do that. > > > > Is was using entry.desktop, maybe it can look up myapp.gmo files instead. >

Re: Review Request 117146: Remove unused dependencies

2014-03-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54518 --- Ship it! Besides the small detail, looks good to me. src/kd

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #6

2014-03-28 Thread KDE CI System
See -- [...truncated 444 lines...] : In member function ‘void FavIconsModule::forceDownloadHostIcon(const KUrl&

Jenkins build is back to normal : krunner_master_qt5 #42

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117122: Cut the dependency between country files and KIO

2014-03-28 Thread Michael Pyne
On Fri, March 28, 2014 15:28:25 David Faure wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117122/#review54458 > --- > > S

Re: Location of docbooks in frameworks repos

2014-03-28 Thread Michael Pyne
On Fri, March 28, 2014 10:16:29 Burkhard Lück wrote: > Am Mittwoch, 26. März 2014, 21:04:01 schrieb Michael Pyne: > > On Wed, March 26, 2014 23:22:22 Burkhard Lück wrote: > > > Hi, > > > > > > I think we need a similar *consistent* scheme for docbook location in > > > frameworks repos. > > > > Ag

Jenkins build is back to stable : kio_master_qt5 #133

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kxmlgui_master_qt5 #88

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kwallet_master_qt5 #76

2014-03-28 Thread KDE CI System
See -- Started by user dfaure Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kwallet_master_qt5] $ /bin/sh -x

Build failed in Jenkins: kxmlgui_master_qt5 #87

2014-03-28 Thread KDE CI System
See -- Started by user dfaure Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kxmlgui_master_qt5] $ /bin/sh -x

Jenkins build is back to normal : kservice_master_qt5 #95

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kconfigwidgets_master_qt5 #40

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #5

2014-03-28 Thread KDE CI System
See -- [...truncated 1390 lines...] ^ :92:15: warning: ‘K4AboutData’

Build failed in Jenkins: krunner_master_qt5 #41

2014-03-28 Thread KDE CI System
See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [krunner_master_qt5] $ /bin

Jenkins build is back to stable : kwindowsystem_master_qt5 » All,LINBUILDER #31

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kxmlgui_master_qt5 #86

2014-03-28 Thread KDE CI System
See -- Started by user dfaure Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kxmlgui_master_qt5] $ /bin/sh -x

Build failed in Jenkins: kwallet_master_qt5 #75

2014-03-28 Thread KDE CI System
See -- Started by user dfaure Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kwallet_master_qt5] $ /bin/sh -x

Re: [kde-frameworks-devel] Regarding entry.desktop files

2014-03-28 Thread Jonathan Riddell
Thanks for the information. My main concern is that kf5 and kde-runtime can be installed alongside the kdelibs4 equivalents without overlapping files. I didn't know there were entry.desktop files in kde-runtime too but I see them now. I've committed a change to kde4support to rename the C entry

Regarding entry.desktop files

2014-03-28 Thread Chusslove Illich
There are now several review requests, in which there is some confusion about what to do/not to do with entry.desktop files in KF5. There are two kinds of these files. One set of entry.desktop files are those in kde-runtime. They are per country, and contain locale information for the KLocale, whi

Build failed in Jenkins: kservice_master_qt5 #94

2014-03-28 Thread KDE CI System
See Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in

Build failed in Jenkins: kconfigwidgets_master_qt5 #39

2014-03-28 Thread KDE CI System
See Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDE

Build failed in Jenkins: kwallet_master_qt5 #74

2014-03-28 Thread KDE CI System
See Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in w

Re: Move KDED out of frameworks?

2014-03-28 Thread Kevin Krammer
On Friday, 2014-03-28, 20:55:02, Boudewijn Rempt wrote: > On Fri, 28 Mar 2014, Kevin Krammer wrote: > > The D-Bus session/user daemon is also something that needs to be treated > > in a platform specific way as a dependency. > > E.g. on Windows there could be a D-Bus installer that applications bun

Build failed in Jenkins: kjobwidgets_master_qt5 #33

2014-03-28 Thread KDE CI System
See Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER)

Build failed in Jenkins: kcompletion_master_qt5 #71

2014-03-28 Thread KDE CI System
See Changes: [faure] Upgrade ECM version requirement and KF5 version. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER)

Jenkins build is back to stable : kcoreaddons_master_qt5 #59

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #30

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Move KDED out of frameworks?

2014-03-28 Thread Kevin Krammer
On Friday, 2014-03-28, 20:26:59, Boudewijn Rempt wrote: > On Fri, 28 Mar 2014, Kevin Krammer wrote: > > D-Bus does run on most platforms, at least on desktop. > > There was a thread on the Qt development list a short while ago which > > discussed enabling QtDBus by default in Windows and Mac builds

Re: Move KDED out of frameworks?

2014-03-28 Thread Boudewijn Rempt
On Fri, 28 Mar 2014, Kevin Krammer wrote: The D-Bus session/user daemon is also something that needs to be treated in a platform specific way as a dependency. E.g. on Windows there could be a D-Bus installer that applications bundle and run if necessary, very much like Games bunlding an DirectX

Build failed in Jenkins: kxmlgui_master_qt5 #85

2014-03-28 Thread KDE CI System
See Changes: [faure] Upgrade ECM version requirement and KF5 version. [faure] Fix test after the removal of deleteEntry("Hidden"). -- Started by remote host 127.0.0.1 with note: Triggered by commit

Re: Move KDED out of frameworks?

2014-03-28 Thread Boudewijn Rempt
On Fri, 28 Mar 2014, Kevin Krammer wrote: D-Bus does run on most platforms, at least on desktop. There was a thread on the Qt development list a short while ago which discussed enabling QtDBus by default in Windows and Mac builds. It might 'run' -- but I still wouldn't want to distribute any a

Review Request 117151: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117151/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kde

Review Request 117150: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117150/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kxm

Review Request 117148: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kco

Re: Review Request 117134: Use QLocale to list all languages

2014-03-28 Thread David Faure
> On March 28, 2014, 3:51 p.m., David Faure wrote: > > Same problem as https://git.reviewboard.kde.org/r/117132/ : > > this code is supposed to list the available translations. The new code > > doesn't do that. > > > > Is was using entry.desktop, maybe it can look up myapp.gmo files instead. >

Review Request 117147: use renamed kf5_entry.desktop file

2014-03-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117147/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kio

Jenkins build is back to stable : kitemmodels_master_qt5 #27

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117146: Remove unused dependencies

2014-03-28 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Aleix Pol Gonzalez
> On March 28, 2014, 4:16 p.m., Commit Hook wrote: > > This review has been submitted with commit > > a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch > > master. > > Aleix Pol Gonzalez wrote: > Why did you ignore my comment? This breaks entry.desktop files usage. >

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-03-28 Thread Aleix Pol Gonzalez
> On March 28, 2014, 3:43 p.m., David Faure wrote: > > Looks wrong, QLocale looks at .ts/.qm files while we mostly use .po/.gmo > > files - different translation system. > > > > Also doubly wrong because uiLanguages() returns the user preferences (e.g. > > for me "en, fr"), which has nothing t

Jenkins build became unstable: ktexteditor_master_qt5 #343

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117134: Use QLocale to list all languages

2014-03-28 Thread Aleix Pol Gonzalez
> On March 28, 2014, 3:51 p.m., David Faure wrote: > > Same problem as https://git.reviewboard.kde.org/r/117132/ : > > this code is supposed to list the available translations. The new code > > doesn't do that. > > > > Is was using entry.desktop, maybe it can look up myapp.gmo files instead. >

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Jonathan Riddell
> On March 28, 2014, 4:16 p.m., Commit Hook wrote: > > This review has been submitted with commit > > a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch > > master. > > Aleix Pol Gonzalez wrote: > Why did you ignore my comment? This breaks entry.desktop files usage. So

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Aleix Pol Gonzalez
> On March 28, 2014, 4:16 p.m., Commit Hook wrote: > > This review has been submitted with commit > > a33377b84b9b312cf5f1f2baae42e6e514731d64 by Jonathan Riddell to branch > > master. Why did you ignore my comment? This breaks entry.desktop files usage. - Aleix ---

Re: Review Request 117145: Make ItemViews a public dependency

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117145/#review54484 --- This review has been submitted with commit 81172dfc0c3c83fe23

Re: Review Request 117145: Make ItemViews a public dependency

2014-03-28 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117145/ --- (Updated March 28, 2014, 6:35 p.m.) Status -- This change has been m

Re: Review Request 117145: Make ItemViews a public dependency

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117145/#review54483 --- Ship it! True. Too bad, though, that the cmake-level Config

Review Request 117145: Make ItemViews a public dependency

2014-03-28 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117145/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: kcoreaddons5 extraction

2014-03-28 Thread Luigi Toscano
On Friday 28 of March 2014 19:28:16 Yuri Chornoivan wrote: > Hi, > > https://projects.kde.org/projects/frameworks/kcoreaddons/repository/revision > s/master/entry/src/lib/kaboutdata.cpp#L258 > > licenseShort = QCoreApplication::translate("KAboutLicense", "@item license > (short name)", "GPL v2");

Re: Review Request 117074: KPluginFactory: remove argumented contructor and componentName()

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117074/#review54482 --- This review has been submitted with commit e3a717f7fa1dc183f2

Re: Review Request 117074: KPluginFactory: remove argumented contructor and componentName()

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117074/#review54481 --- This review has been submitted with commit ea11dab0ed90087272

Re: Review Request 117074: KPluginFactory: remove argumented contructor and componentName()

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117074/ --- (Updated March 28, 2014, 6:14 p.m.) Status -- This change has been m

Re: Review Request 117074: KPluginFactory: remove argumented contructor and componentName()

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117074/#review54435 --- Ship it! Ship It! - David Faure On March 26, 2014, 4:05 a.

Re: Review Request 117135: Remove fake MIME types

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117135/#review54451 --- Ship it! Ship It! - David Faure On March 28, 2014, 2:56 p.

Re: Review Request 117135: Remove fake MIME types

2014-03-28 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117135/ --- (Updated March 28, 2014, 3:02 p.m.) Status -- This change has been m

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/ --- (Updated March 28, 2014, 3 p.m.) Status -- This change has been mark

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread David Faure
> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: > > What about QStandardPaths::findExecutable? Actually this one should look > > into libexec too (at least the equivalent KStandardDirs::findExe used to). > > Alex Merry wrote: > I'm pretty sure QStandardPaths won't look at libexec

Re: Review Request 117136: Expose KAssistantDialog buttons

2014-03-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117136/#review54445 --- Ship it! src/kassistantdialog.h

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-28 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/ --- (Updated March 28, 2014, 2:46 p.m.) Review request for Build System, Extr

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/#review54450 --- This review has been submitted with commit d3d31b88f829c76aaf

Build failed in Jenkins: solid_master_qt5 #34

2014-03-28 Thread KDE CI System
See Changes: [afiestas] Begin the breaking up of solidshell into specialized components so that it can be portable. Right now solid-hardware is not built; if you want the functionality of solidshell, use solid-[powermanagement,bluetooth,net

Re: Final kde-runtime splitting plan

2014-03-28 Thread David Faure
On Tuesday 25 March 2014 23:01:39 Luigi Toscano wrote: > Àlex Fiestas ha scritto: > > Hi there > > > > Today Aleix and I are starting to split kde-runtime so we have gone > > through > > all the components again making sure that everything has a suitable > > destination. The result is this [1] wik

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117137/#review54456 --- Ship it! Ship It! - David Faure On March 28, 2014, 3:07 p.

Re: Review Request 117078: Allow compiling kio on windows

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117078/#review54455 --- Thanks for this work! src/core/kioglobal_p.h

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
> On March 28, 2014, 2:58 p.m., David Faure wrote: > > I'm confused, I thought the Qt5 way was no desktop file and instead, having > > the info compiled into the plugin (using json)? This contradicts the commit > > log. Well, it actually comes from KPluginInfo. I just assumed the comment in t

Jenkins build is back to normal : solid_master_qt5 #35

2014-03-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117132: Use QLocale for figuring out what languages we're translated into

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117132/#review54463 --- Looks wrong, QLocale looks at .ts/.qm files while we mostly us

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117087/#review54467 --- This review has been submitted with commit a33377b84b9b312cf5

Re: Review Request 117087: co-installability: rename entry.desktop to kf5_entry.desktop

2014-03-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117087/ --- (Updated March 28, 2014, 4:16 p.m.) Status -- This change has been m

Review Request 117136: Expose KAssistantDialog buttons

2014-03-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117136/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117137/ --- Review request for KDE Frameworks and David Faure. Repository: kcmutils

Re: [kde-promo] Releasing Deprecated modules and Tier 4 Definition

2014-03-28 Thread David Faure
On Tuesday 18 March 2014 17:32:58 Markus Slopianka wrote: > On Tuesday 18 March 2014 13:37:01 Aleix Pol wrote: > > Can we maybe agree that we want an extra value in the .yaml > > file > > indicating the maturity of the project? > > It's not about maturity, it's about security. QtWebKit is no longe

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117137/#review54457 --- This review has been submitted with commit 3d717fac6356c38748

Re: Review Request 117112: Make KPLuginLoader encapsulate QPluginLoader, rather than inheriting

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117112/ --- (Updated March 28, 2014, 5:36 p.m.) Status -- This change has been m

Re: Review Request 117112: Make KPLuginLoader encapsulate QPluginLoader, rather than inheriting

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117112/#review54473 --- This review has been submitted with commit 2d74663118c359208b

Re: Review Request 117052: Add ECMSetupQtTranslations

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117052/#review54446 --- Ship it! Ship It! - Alex Merry On March 28, 2014, 1:46 p.m

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Alex Merry
> On March 24, 2014, 3:41 p.m., Alex Merry wrote: > > The correct solution is to get drkonqi merged into kcrash (see > > http://community.kde.org/Frameworks/Epics/New_Runtime_Organization). > > Aleix Pol Gonzalez wrote: > Agreed. If somebody has the time, it would be interesting to figure o

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review54439 --- I'm all for extending QStandardPaths, but obviously %KDEROOT%

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-28 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/ --- (Updated March 28, 2014, 4:18 p.m.) Status -- This change has been m

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review54468 --- This review has been submitted with commit 4846b50aea0bc22622

Re: Move KDED out of frameworks?

2014-03-28 Thread Kevin Krammer
On Friday, 2014-03-28, 12:54:42, Aleix Pol wrote: > On Fri, Mar 28, 2014 at 12:32 PM, Àlex Fiestas wrote: > > On Friday 28 March 2014 11:30:25 Alex Merry wrote: > > > In principle, I agree. In practice, a lot of our frameworks have a > > > runtime dependency of some sort on it.[0] > > > > > > Al

Re: Review Request 117125: start_kdeinit: Use capabilities instead of SUID

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117125/#review54461 --- src/start_kdeinit/start_kdeinit.c

Re: Review Request 117070: remove check for Linux kernel >= 2.6.14

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117070/#review54447 --- Ship it! OK. - David Faure On March 25, 2014, 10:22 p.m.,

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117137/ --- (Updated March 28, 2014, 3:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread Aleix Pol Gonzalez
> On March 28, 2014, 2:13 p.m., David Faure wrote: > > How does findExecutable() help at all? You plan on adding libexec to your > > $PATH? KStandardDirs::findExe used to look into libexec, IIRC. Maybe we could make it work. Or do something completely different. - Aleix ---

Re: Review Request 117122: Cut the dependency between country files and KIO

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117122/#review54458 --- Ship it! For the curious like me, see git show 8ec9cef7c68d2d

Re: Review Request 117134: Use QLocale to list all languages

2014-03-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117134/#review54465 --- Same problem as https://git.reviewboard.kde.org/r/117132/ : th

Re: Review Request 117016: Allow overriding DrKonqi lookup directories by PATH

2014-03-28 Thread David Faure
> On March 28, 2014, 2:13 p.m., David Faure wrote: > > How does findExecutable() help at all? You plan on adding libexec to your > > $PATH? > > Aleix Pol Gonzalez wrote: > KStandardDirs::findExe used to look into libexec, IIRC. > > Maybe we could make it work. > Or do something

Re: Review Request 117135: Remove fake MIME types

2014-03-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117135/#review54452 --- This review has been submitted with commit 36ff1bf60c9b12c28e

Re: Review Request 117137: Remove use of KPluginFactory::componentName()

2014-03-28 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117137/ --- (Updated March 28, 2014, 3:27 p.m.) Status -- This change has been m

  1   2   >