-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117132/#review54463
-----------------------------------------------------------


Looks wrong, QLocale looks at .ts/.qm files while we mostly use .po/.gmo files 
- different translation system.

Also doubly wrong because uiLanguages() returns the user preferences (e.g. for 
me "en, fr"), which has nothing to do with "how many languages are actually 
installed" (e.g. there could be about 54).

- David Faure


On March 28, 2014, 11:21 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117132/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 11:21 a.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and Chusslove Illich.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> -------
> 
> Instead of asking the file-system what languages the application is 
> translated into, ask QLocale what languages we have available instead.
> 
> 
> Diffs
> -----
> 
>   src/khelpmenu.cpp 4f6ce7b 
> 
> Diff: https://git.reviewboard.kde.org/r/117132/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to