-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117135/#review54451
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On March 28, 2014, 2:56 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117135/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 2:56 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> These fake MIME types cause warnings when running update-mime-database.
> 
> I would also add a porting notes entry under "KDECore changes" advising to 
> change uri/foo -> x-scheme-handler/foo, all/allfiles -> 
> application/octet-stream, & all/all -> 
> application/octet-stream+inode/directory.
> 
> 
> Diffs
> -----
> 
>   src/mimetypes/kde5.xml 778cf4e01c07c948b5c11bd9c3cdacd9edef8835 
> 
> Diff: https://git.reviewboard.kde.org/r/117135/diff/
> 
> 
> Testing
> -------
> 
> I couldn't find left-over references to these MIME types in frameworks-ported 
> stuff using lxr.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to