> On March 28, 2014, 2:58 p.m., David Faure wrote: > > I'm confused, I thought the Qt5 way was no desktop file and instead, having > > the info compiled into the plugin (using json)? This contradicts the commit > > log.
Well, it actually comes from KPluginInfo. I just assumed the comment in the code was correct about getting it from the .desktop file, but presumeably it's out of date. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117137/#review54449 ----------------------------------------------------------- On March 28, 2014, 2:49 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117137/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 2:49 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kcmutils > > > Description > ------- > > Remove use of KPluginFactory::componentName() > > This path would never have succeeded, as plugins do not have component > data compiled into them any more. Go straight to extracting the > information from the desktop file instead. > > > Diffs > ----- > > src/kpluginselector.cpp 34e4a83325e52babae4d28691abaf90f3576f379 > > Diff: https://git.reviewboard.kde.org/r/117137/diff/ > > > Testing > ------- > > KCMUtils now builds with https://git.reviewboard.kde.org/r/117074/ applied to > kservice. No unit tests :-( > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
