Re: KF5 Update Meeting Minutes 2014-w10

Hello, On Thursday 06 March 2014 02:13:36 Valentin Rusu wrote: > Catching up with KF5 progress... > > On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote: > > * Repository merges for kwallet and kdnssd still reported as pending... > > What's that? Is that about merging 4.xx repository wit

Re: KSpeech

Took a quick read through that just now and it looks pretty promising from what I saw. I guess I don't know my way around gerrit very well because I couldn't see a place to comment on the code like reviewboard. Really the only difference between jovie and that class are the following: 1. jovie has

Re: KF5 Update Meeting Minutes 2014-w10

Hello, Catching up with KF5 progress... On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote: > * Repository merges for kwallet and kdnssd still reported as pending... What's that? Is that about merging 4.xx repository with the KF5 one? > * afiestas has kwallet patches in need of review

Re: KSpeech

On Tuesday 4. March 2014 16.43.10 Jeremy Whiting wrote: > Hello all, I've realized a bit ago that kspeech was not included in > the kdelibs split (probably because it was in staging at the time and > didn't conform to the other framework policies yet). I've cleaned it > up a bit and put it in my sc

Re: Review Request 116616: Remove unused find-modules back to the attic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/#review52202 --- Ship it! Ship It! - Kevin Ottens On March 5, 2014, 2:31 p.

Re: Review Request 116096: Re-enable autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/#review52201 --- Ship it! Ship It! - Kevin Ottens On March 5, 2014, 12:08 p

Re: Review Request 116604: Allow directories with . as output for meinproc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116604/#review52091 --- src/meinproc.cpp

Re: Review Request 116615: Remove deprecated method languageForEncoding()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116615/ --- (Updated March 5, 2014, 3:05 p.m.) Status -- This change has been ma

Re: Review Request 116615: Remove deprecated method languageForEncoding()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116615/#review52086 --- Ship it! "This function will be removed before KDE4 is releas

Review Request 116616: Remove unused find-modules back to the attic

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116616/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 116615: Remove deprecated method languageForEncoding()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116615/ --- Review request for KDE Frameworks, David Faure and Kevin Ottens. Reposito

Re: Review Request 116561: Drop KWindowEffects::showWindowThumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116561/#review52080 --- This review has been submitted with commit e11d1c9c0f91fe5ac5

Re: Review Request 116561: Drop KWindowEffects::showWindowThumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116561/ --- (Updated March 5, 2014, 1:47 p.m.) Status -- This change has been ma

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (be

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52077 --- This review has been submitted with commit 68fa427587a38805f2

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review52076 --- This review has been submitted with commit 9b32aab411fc79d00f

Re: Review Request 116598: Check versions for individual components of Wayland

> On March 5, 2014, 12:31 p.m., Alex Merry wrote: > > Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What > > shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl). > > Alex Merry wrote: > I hadn't realised that about pkg_check_modules(), though. I'l

Re: Review Request 116598: Check versions for individual components of Wayland

> On March 5, 2014, 1:31 p.m., Alex Merry wrote: > > Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What > > shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl). > > Alex Merry wrote: > I hadn't realised that about pkg_check_modules(), though. I'll

Re: Review Request 116598: Check versions for individual components of Wayland

> On March 5, 2014, 12:31 p.m., Alex Merry wrote: > > Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What > > shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl). I hadn't realised that about pkg_check_modules(), though. I'll have to update the docs I

Re: Review Request 116598: Check versions for individual components of Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review52067 --- Note that find_package(Wayland COMPONENTS Client Egl) *should*

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

> On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote: > > The problem with doing this in support code is that it is not strictly > > source compatible. An example this would break is if you want to embed the > > value of QT_QMAKE_EXECUTABLE into a C++ executable using something like > > add_definit

Re: Review Request 116567: Implement fuzzy image matching in readtest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/ --- (Updated March 5, 2014, 12:11 p.m.) Status -- This change has been m

Re: Review Request 116567: Implement fuzzy image matching in readtest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/#review52064 --- This review has been submitted with commit 895305050c6af3e98b

Re: Review Request 116567: Implement fuzzy image matching in readtest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/#review52065 --- This review has been submitted with commit 0f795e66256b7ce0b9

Re: Review Request 116096: Re-enable autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/ --- (Updated March 5, 2014, 12:08 p.m.) Review request for KDE Frameworks.

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

> On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote: > > The problem with doing this in support code is that it is not strictly > > source compatible. An example this would break is if you want to embed the > > value of QT_QMAKE_EXECUTABLE into a C++ executable using something like > > add_definit

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 5, 2014, 12:04 p.m.) Status -- This change has been d

Re: Review Request 116096: Re-enable autotests

> On March 4, 2014, 8:40 p.m., Kevin Ottens wrote: > > autotests/proxymodeltestsuite/CMakeLists.txt, line 89 > > > > > > Hm, why removing this block while using if(FALSE) on the one above? I'd > > expect either b

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/ --- (Updated March 5, 2014, 11:55 a.m.) Status -- This change has been m

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207/#review52059 --- This review has been submitted with commit 71febbb162847ddf1b

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/#review52058 --- This review has been submitted with commit 591ebf5e450cb9756c

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/ --- (Updated March 5, 2014, 11:53 a.m.) Status -- This change has been m

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

> On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote: > > The problem with doing this in support code is that it is not strictly > > source compatible. An example this would break is if you want to embed the > > value of QT_QMAKE_EXECUTABLE into a C++ executable using something like > > add_definit

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 5, 2014, 11:49 a.m.) Status -- This change has been m

Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116603/ --- (Updated March 5, 2014, 11:49 a.m.) Review request for KDE Frameworks.

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review52056 --- This review has been submitted with commit a6c75f16514a2f8bb5

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review52055 --- Ship it! Ship It! - Kevin Ottens On March 5, 2014, 11:14 a

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- (Updated March 5, 2014, 12:14 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

> On March 4, 2014, 9:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. > > Stephen Kelly wrote: > Please provide a minimal testcase. The feature is unit tested in cmake. > If it's broken, it needs to be fixed soon (be

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review52049 --- This review has been submitted with commit 19429ffd51fdefbf89

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/ --- (Updated March 5, 2014, 10:33 a.m.) Status -- This change has been m

Re: Review Request 116608: KPasswordDialog: Add method to access the buttonBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/#review52048 --- Ship it! Thanks, this supersedes 116603. - Christoph Feck

Jenkins build is back to stable : kdelibs_stable #1027

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116609: Fix all properties flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116609/ --- (Updated March 5, 2014, 9:51 a.m.) Status -- This change has been ma

Re: Review Request 116609: Fix all properties flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116609/#review52045 --- This review has been submitted with commit c0fafea608b0a82390

Review Request 116610: Use flag types in NETRootInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116610/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: KSpeech

Hello, On Tuesday 04 March 2014 16:43:10 Jeremy Whiting wrote: > I've realized a bit ago that kspeech was not included in > the kdelibs split (probably because it was in staging at the time and > didn't conform to the other framework policies yet). I've cleaned it > up a bit and put it in my scrat

Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.

Hello, On Tuesday 04 March 2014 22:54:42 David Faure wrote: > On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote: > It wasn't that transparent at all - a number of modules have been re- > downloaded in a different location in my local source directory: > > * plasma-frameworks moved under playg

Re: Review Request 116609: Fix all properties flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116609/#review52043 --- Ship it! Ship It! - David Edmundson On March 5, 2014, 9:12

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? > > Kevin Ottens wrote: > This

Re: Review Request 116541: Fix compiler error when using clang:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116541/#review52037 --- This review has been submitted with commit 7ed8ac1ae23a31d2eb

Re: Review Request 116544: Fix clang compilation warning:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116544/#review52038 --- This review has been submitted with commit 6c4f7f84dd13268534

Re: Review Request 116541: Fix compiler error when using clang:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116541/ --- (Updated March 5, 2014, 9:27 a.m.) Status -- This change has been ma

Re: Review Request 116544: Fix clang compilation warning:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116544/ --- (Updated March 5, 2014, 9:27 a.m.) Status -- This change has been ma

Re: Review Request 116542: Fix compilation with clang 3.4.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116542/ --- (Updated March 5, 2014, 9:26 a.m.) Status -- This change has been ma

Re: Review Request 116542: Fix compilation with clang 3.4.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116542/#review52036 --- This review has been submitted with commit 1a6286034ddd131030

Re: Review Request 116545: Fix KHTML compilation when using clang.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116545/ --- (Updated March 5, 2014, 9:26 a.m.) Status -- This change has been ma

Re: Review Request 116545: Fix KHTML compilation when using clang.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116545/#review52035 --- This review has been submitted with commit dadacaf995170f44e6

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On March 4, 2014, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Ok, I just realized this was being dealt with and I did a different patch: > > https://git.reviewboard.kde.org/r/116573/ > > > > I think that having UI strings on a header file is quite bad TBH, but since > > I see there's consensus

Re: kjsembed tier (Re: Build failed in Jenkins: kjsembed_master_qt5 #27)

On Tue, Mar 4, 2014, at 23:58, David Faure wrote: > > Yeah I think kross is the main user. Aurelien, the question on "is it > really > important to push it down" is for you, you wrote " It's a bit sad to bump > it > from tier 2 to tier 3 just because of this." :) > > I tend to agree that the cur

Review Request 116609: Fix all properties flags

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116609/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

> On Feb. 20, 2014, 1:07 p.m., Kevin Ottens wrote: > > Aren't the concern raised initially on that patch addressed now? Please > > make a second round of reviews or ship it. > > Kevin Ottens wrote: > More than a week with no reaction, should it be discarded? I decided to discard it for the

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/ --- (Updated March 5, 2014, 10:11 a.m.) Status -- This change has been d

Re: Review Request 116088: Remove FindDBusMenuQt5.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/ --- (Updated March 5, 2014, 9:10 a.m.) Status -- This change has been ma

Re: Review Request 116588: Improve the README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/ --- (Updated March 5, 2014, 9:09 a.m.) Status -- This change has been ma

Re: Review Request 116088: Remove FindDBusMenuQt5.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/#review52032 --- This review has been submitted with commit 1332dd022f1e1fc88a

Re: Review Request 116588: Improve the README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/#review52031 --- This review has been submitted with commit f61c5bb6a7cacfcd3c

Re: Review Request 116598: Check versions for individual components of Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/ --- (Updated March 5, 2014, 9 a.m.) Status -- This change has been marke

Re: Review Request 116598: Check versions for individual components of Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review52029 --- This review has been submitted with commit a5e59578725c79cd8f

Review Request 116608: KPasswordDialog: Add method to access the buttonBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116608/ --- Review request for KDE Frameworks, Aleix Pol Gonzalez and Christoph Feck.

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

> On March 4, 2014, 8:45 p.m., Kevin Ottens wrote: > > And I agree with Aurélien, a bug should be filed and Stephen involved in > > that issue. Please provide a minimal testcase. The feature is unit tested in cmake. If it's broken, it needs to be fixed soon (before the final 3.0 release). -

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

> On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? > > Kevin Ottens wrote: > This