----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116544/#review52038 -----------------------------------------------------------
This review has been submitted with commit 6c4f7f84dd1326853475d10e503f220e4555e5e2 by Milian Wolff to branch master. - Commit Hook On March 2, 2014, 8:53 p.m., Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116544/ > ----------------------------------------------------------- > > (Updated March 2, 2014, 8:53 p.m.) > > > Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. > > > Repository: khtml > > > Description > ------- > > Fix clang compilation warning: > > khtml/src/xml/dom_stringimpl.h:60:13: warning: cast from 'char *' > to 'QChar *' increases required alignment from 1 to 2 [-Wcast-align > s = (QChar*) new cha sizeof(QChar)*( havestr ? len : 1 ) ; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Note that this line of code is pretty odd I have to say. It this > supposed to be an optimization to prevent the default ctor/dtor of > QChar to be called? Is it really worth it here? > > > Diffs > ----- > > src/xml/dom_stringimpl.h 114101d525309e423f50c5164d83afee8c634413 > > Diff: https://git.reviewboard.kde.org/r/116544/diff/ > > > Testing > ------- > > > Thanks, > > Milian Wolff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
