> On March 4, 2014, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Ok, I just realized this was being dealt with and I did a different patch: > > https://git.reviewboard.kde.org/r/116573/ > > > > I think that having UI strings on a header file is quite bad TBH, but since > > I see there's consensus I'll discard it. > > Alex Merry wrote: > Somewhat confusingly, the diff in this RR was not what was committed, but > instead the diff in the comments. See > http://commits.kde.org/kio/bf41a9aa94881db1d7f85c41aa35277c6e118574
My fault. I suggested Matthieu to do this, but that may not have been the best idea after all. - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116103/#review51844 ----------------------------------------------------------- On March 3, 2014, 9:59 p.m., Matthieu Gallien wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116103/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 9:59 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > include/KF5/KIOCore/kio/slavebase.h is including headers from KI18N and is > publically installed. > > > Diffs > ----- > > KF5KIOConfig.cmake.in 3a947b7 > src/core/CMakeLists.txt d897e37 > > Diff: https://git.reviewboard.kde.org/r/116103/diff/ > > > Testing > ------- > > > Thanks, > > Matthieu Gallien > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
