> On March 4, 2014, 8:40 p.m., Kevin Ottens wrote: > > autotests/proxymodeltestsuite/CMakeLists.txt, line 89 > > <https://git.reviewboard.kde.org/r/116096/diff/1/?file=246357#file246357line89> > > > > Hm, why removing this block while using if(FALSE) on the one above? I'd > > expect either both to disappear or both to use if(FALSE).
Because the conditions are opposites (the higher one is "if(NOT proxymodeltestsuite_standalone)"). I guess the actual condition should go away in the higher one, though, and just leave the if(FALSE). - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/#review51943 ----------------------------------------------------------- On Feb. 26, 2014, 5:49 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116096/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 5:49 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kitemmodels > > > Description > ------- > > Re-enable autotests > > modeltest.(cpp|h) are taken from Qt 5.3. The license header has been > trimmed to clarify which license we are using it under, and to reflect > the fact we use a COPYING.LIB file instead of LICENSE.LGPL. > > Grantlee is disabled. That apparently affects some sort of logging > functionality, but I haven't really investigated it. > > > Diffs > ----- > > autotests/klinkitemselectionmodeltest.cpp > e1a47e4cf58e85d690c58fb1b40bfdd8cfb81431 > autotests/kselectionproxymodeltestsuite.h > 6204b7733f995614c43930af03d12d13e0cb2a3f > autotests/proxymodeltestsuite/CMakeLists.txt > 972226b7dd3477b7d064ececb307609e67d81670 > autotests/proxymodeltestsuite/eventloggerregister.cpp > 6be780108c71db6c32cfbb2c88524366435ea301 > autotests/proxymodeltestsuite/modelselector.h > c1163084170d4409112949057562abbfa909dc14 > autotests/proxymodeltestsuite/modeltest.h > 20d5c36e32e69bb69fffad86ccc02e44bfade425 > autotests/proxymodeltestsuite/modeltest.cpp > 51ad27f3fef5cf0d62e92eb149e4cf9149b45e95 > CMakeLists.txt d153ba3d658ba70a0dca2b9e04b6cdd1e17d9db3 > autotests/bihash/CMakeLists.txt 44c965c7597ac48c81bba70f07979b51bf8547aa > > Diff: https://git.reviewboard.kde.org/r/116096/diff/ > > > Testing > ------- > > Tests build. 3 out of 4 pass. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
