Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/#review51000 --- This review has been submitted with commit c8168fe82ee26af0ec

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/ --- (Updated Feb. 27, 2014, 7:52 a.m.) Status -- This change has been ma

Frameworks sprint: Register now!

Hello all, If you didn't yet, please register for the upcoming sprint: https://sprints.kde.org/sprint/224 Especially if you're not from Barcelona, it's necessary for budgeting the sprint, booking the accommodation, etc. The guys in Barcelona are kind enough to host us, so please let's be nice g

Re: clang fails to build khtml

On Wed, February 26, 2014 22:43:31 Milian Wolff wrote: > But what about this: > > In file included from src/ecma/kjs_traversal.cpp:21: > src/kjs_traversal.lut.h:49:18: error: constant expression evaluates to > 4294967295 which cannot be narrowed to type 'int' [-Wc++11-narrowing] >{ "SHOW_ALL",

Re: kdesrc-build: stop after failure? --truly-verbose?

On Wed, February 26, 2014 22:30:48 Milian Wolff wrote: > Hey, > > not sure this is the right list. I noticed that kdesrc-build happily > continues building even when a module failed to build. Is this desired? Yes, it's on purpose. The idea is that most people are not building KDE for the first t

Re: kactivities5 build failure

On Wed, February 26, 2014 14:54:37 Ivan Čukić wrote: > > > Qt5.3? > > > > It fails for me as well with the same error. Yes, Qt 5.3. > > I'm not going to be able to deal with Qt 5.3 until next version of plasma is > released since we are tiesd to 5.2. > > If anyone provides a patch, it would be a

Re: building Solid

On Wed, February 26, 2014 13:51:52 Dominik Haumann wrote: > PS: It's never (!) a good idea to add a custom type that has Q* naming > style. It leads to totally unnecessary issues like this one ;) I agree completely with this. If we add a typedef it should always be with a symbol under our own

Re: kdesrc-build: stop after failure? --truly-verbose?

On Wed, Feb 26, 2014 at 2:30 PM, Milian Wolff wrote: > Hey, > > not sure this is the right list. I noticed that kdesrc-build happily continues > building even when a module failed to build. Is this desired? I find it highly > unintuitive, esp. as most modules failing at the beginning will mean all

Re: [kde-doc-english] Core documentation repository (was: Review Request 116038: replace old included sections with links to fundamentals)

> On Wed, Feb 26, 2014 at 3:52 PM, Luigi Toscano > wrote: >> T.C. Hollingsworth wrote: >>> Also, kio help:/ requires the "documentationnotfound" docbook to >>> display as sort of a 404 error, so that needs to be universally >>> available too. >> So documentationnotfound docbook should be moved to

Re: [kde-doc-english] Core documentation repository (was: Review Request 116038: replace old included sections with links to fundamentals)

Hi frameworks devs! We thought we'd solicit some input from you all on this as well. On Wed, Feb 26, 2014 at 3:52 PM, Luigi Toscano wrote: > T.C. Hollingsworth wrote: >> On Tue, Feb 25, 2014 at 4:38 AM, Luigi Toscano >> wrote: >>> I'm not sure if it enough: what if fundamentals is not installe

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D However, I wonder if those calls should really be in the header. I have no idea what catalogue they will use at runtime

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #79

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #79

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? Ignore me, there's i18n calls in there :D - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #78

See -- [...truncated 618 lines...] [ 42%] Scanning dependencies of target plasmapkg2 Scanning dependencies of target plasmaextracomponentsplugin Building CXX object

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #78

See -- [...truncated 620 lines...] Scanning dependencies of target plasma_dataengine_example_sourcesOnRequest Scanning dependencies of target plasmapkg2 Scanning depen

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #77

See Changes: [notmart] add a building version of interactive console [notmart] port Package usage [notmart] instantiate the console [notmart] restore loadScriptInInteractiveConsole() [notmart]

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #77

See Changes: [notmart] add a building version of interactive console [notmart] port Package usage [notmart] instantiate the console [notmart] restore loadScriptInInteractiveConsole() [notmart] po

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116103/#review50988 --- have you tried removing the include? - Albert Astals Cid On

Re: kdesrc-build: stop after failure? --truly-verbose?

On Wed, Feb 26, 2014 at 10:30 PM, Milian Wolff wrote: > Hey, > > not sure this is the right list. I noticed that kdesrc-build happily continues > building even when a module failed to build. Is this desired? I find it highly > unintuitive, esp. as most modules failing at the beginning will mean al

qt5 polkit-qt-1 and kdesrc-build

Hey all, I today sat down trying to finally get a KF5 & kdesrc-build setup done. After lots of issues related to missing dependencies not listed (fixed now) on techbase, I hit an issue with kauth, namely that it tried to build agains tthe _qt4_ version of polkit-1. Can/should this not be forbid

clang fails to build khtml

Hey all, apparently noone is trying to build khtml with clang. I spotted this one: src/misc/AtomicString.cpp:175:28: error: non-constant-expression cannot be narrowed from type 'int' to 'unsigned int' in initializer list [-Wc++11-narrowing] UCharBuffer buf = { s, length };

kdesrc-build: stop after failure? --truly-verbose?

Hey, not sure this is the right list. I noticed that kdesrc-build happily continues building even when a module failed to build. Is this desired? I find it highly unintuitive, esp. as most modules failing at the beginning will mean all following modules will fail as well if they depend on said

Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116103/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116056/ --- (Updated Feb. 26, 2014, 10:39 p.m.) Status -- This change has been d

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

> On Feb. 26, 2014, 12:07 p.m., Alex Merry wrote: > > ioslave/CMakeLists.txt, line 9 > > > > > > I found I needed to link against KF5::I18n; I wonder why you didn't? The problem is in KIO (/home/mgallien/kde/inclu

Re: Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116062/#review50985 --- This review has been submitted with commit 6a810298e56c2b1cc9

Re: Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116062/ --- (Updated Feb. 26, 2014, 9:09 p.m.) Status -- This change has been ma

Re: Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115984/#review50984 --- This review has been submitted with commit 3698faa2c1f2164a28

Re: Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115984/ --- (Updated Feb. 26, 2014, 9:05 p.m.) Status -- This change has been ma

Review Request 116098: Use KDEInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ --- Review request for KDE Frameworks. Repository: libnm-qt Description ---

Re: KItemModels, Solid & KJS licenses

hi, I confirm that I would be happy to the files listed below relicensed from GPL to LGPLv2+. Seriously, I don't really care that much if its gpl or lgpl, as long as its available for everyone who want to improve it ;> Or ,if possible, I would relicense it to LGPLv2+ & beer license, but sadly they

Review Request 116096: Re-enable autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/ --- Review request for KDE Frameworks. Repository: kitemmodels Description

Re: KItemModels, Solid & KJS licenses

On 20/02/14 11:41, Alex Merry wrote: >> [1] https://build.opensuse.org/request/show/223061 > > KItemModels > > kcheckableproxymodel.(cpp|h) is Stephen Kelly (and, for safety, David > Faure). Changed. > modeltest.(cpp|h) were taken from Qt Concurrent, and subsequently > modified by Stephen Kelly

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #76

See Changes: [notmart] add a building version of interactive console [notmart] port Package usage [notmart] instantiate the console [notmart] restore loadScriptInInteractiveConsole() [notmart]

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #76

See Changes: [notmart] add a building version of interactive console [notmart] port Package usage [notmart] instantiate the console [notmart] restore loadScriptInInteractiveConsole() [notmart] po

KNotify merge in KNotification now in branch

Hey, so as the patch on RB was apparently too big to review in 14 days, I tried to divide it in smaller commits and pushed into a branch mklapetek/knotify-merge in kde:knotifications. So please have a look at that, the commitdiffs might be a bit confusing as it was created from the big diff, but

Review Request 116090: Use $ instead of get_target_property(... LOCATION)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116090/ --- Review request for KDE Frameworks. Repository: kde4support Description

Review Request 116087: KCrash: remove usage of strlcpy

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/ --- Review request for KDE Frameworks. Repository: kcrash Description -

Review Request 116088: Remove FindDBusMenuQt5.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/ --- Review request for KDE Frameworks. Repository: knotifications Descripti

Re: Review Request 116079: Be more explicit with QFile include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/ --- (Updated Feb. 26, 2014, 4:36 p.m.) Status -- This change has been di

Re: Review Request 115695: Rework KNotification to work without KNotify daemon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115695/ --- (Updated Feb. 26, 2014, 4:53 p.m.) Status -- This change has been di

Re: Review Request 116079: Be more explicit with QFile include

> On Feb. 26, 2014, 4:36 p.m., Aurélien Gâteau wrote: > > My memory may be failing me, but I think it was actually decided to go the > > other way around for Qt5 includes: not prepending the module dir. Can > > anyone else confirm? This should be mentioned in the framework policies, I > > thin

Re: Review Request 116062: Hide private slots in KCompletionBox and modify d-pointer in KCompletionMatches

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116062/#review50953 --- Ship it! Ship It! - Aurélien Gâteau On Feb. 25, 2014, 11:3

Re: Review Request 116079: Be more explicit with QFile include

> On Feb. 26, 2014, 3:36 p.m., Aurélien Gâteau wrote: > > My memory may be failing me, but I think it was actually decided to go the > > other way around for Qt5 includes: not prepending the module dir. Can > > anyone else confirm? This should be mentioned in the framework policies, I > > thin

Re: Review Request 116079: Be more explicit with QFile include

> On Feb. 26, 2014, 3:36 p.m., Aurélien Gâteau wrote: > > My memory may be failing me, but I think it was actually decided to go the > > other way around for Qt5 includes: not prepending the module dir. Can > > anyone else confirm? This should be mentioned in the framework policies, I > > thin

Re: Review Request 116079: Be more explicit with QFile include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/#review50945 --- My memory may be failing me, but I think it was actually decid

Re: KDNSSD merge

On 26/02/14 13:36, Nicolas Lécureuil wrote: > Le mercredi 26 février 2014 11:54:16 Alex Merry a écrit : >> On 26/02/14 10:01, Alex Merry wrote: >>> Actually, having slept on it, my suggestion is: >>> >>> - rename kdnssd to zeroconf-ioslave >>> - rename kdnssd-framework to kdnssd >>> - merge the fra

Re: Review Request 116080: find_dependency: Update to match CMake's version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116080/ --- (Updated Feb. 26, 2014, 3:07 p.m.) Review request for Build System, Extra

Re: KItemModels, Solid & KJS licenses

On Thursday 20 of February 2014 11:41:48 Alex Merry wrote: > CC'd people: please can you confirm that you would be happy to have the > files listed below relicensed from GPL to LGPLv2+? Small ping :) It would be awesome if we could get this sorted for alpha2 Cheers, Hrvoje >

Re: Review Request 116025: Add documentation about writing find modules

> On Feb. 25, 2014, 3:56 p.m., Stephen Kelly wrote: > > docs/writing-find-modules.md, line 9 > > > > > > You can link to > > > > http://www.cmake.org/cmake/help/git-master/manual/cmake-packages.7.html > >

Re: kactivities5 build failure

> > Qt5.3? > > It fails for me as well with the same error. Yes, Qt 5.3. I'm not going to be able to deal with Qt 5.3 until next version of plasma is released since we are tiesd to 5.2. If anyone provides a patch, it would be appreciated. Cheerio, Ivan

Re: KDNSSD merge

On 02/27/2014 12:36 AM, Nicolas Lécureuil wrote: > Le mercredi 26 février 2014 11:54:16 Alex Merry a écrit : >> On 26/02/14 10:01, Alex Merry wrote: >>> Actually, having slept on it, my suggestion is: >>> >>> - rename kdnssd to zeroconf-ioslave >>> - rename kdnssd-framework to kdnssd >>> - merge th

Re: KDNSSD merge

Le mercredi 26 février 2014 11:54:16 Alex Merry a écrit : > On 26/02/14 10:01, Alex Merry wrote: > > Actually, having slept on it, my suggestion is: > > > > - rename kdnssd to zeroconf-ioslave > > - rename kdnssd-framework to kdnssd > > - merge the frameworks branch of zeroconf-ioslave into kio >

Re: Re: kactivities5 build failure

On Wednesday, February 26, 2014 14:00:45 Ivan Čukić wrote: > On Wednesday, 26. February 2014. 13.15.51 Treeve Jelbert wrote: > > doing a clean rebuild > > > > gcc-4.8.2 > > Qt5.3? It fails for me as well with the same error. Yes, Qt 5.3. Greetings, Dominik

Re: kactivities5 build failure

On Wednesday, 26. February 2014. 13.15.51 Treeve Jelbert wrote: > doing a clean rebuild > > gcc-4.8.2 Qt5.3? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Re: Re: building Solid

On Wednesday, February 26, 2014 07:52:21 Martin Gräßlin wrote: > On Tuesday 25 February 2014 21:27:02 Dominik Haumann wrote: > > On Tuesday 25 February 2014 20:34:38 Dominik Haumann wrote: > > > Hi, > > > > > > a fresh Qt5 from stable branch, and a fresh frameworks build results in > > > this er

Re: Review Request 115984: Implement the d-pointer in KCompletionBase as in the other classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115984/#review50926 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On Feb. 24

kactivities5 build failure

doing a clean rebuild gcc-4.8.2 FAILED: /var/lib/sorcery/build/c++ -DKCOREADDONS_LIB -DQT_CORE_LIB - DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -D_GNU_SOURCE - D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -march=native -mtune=native -m64 - pipe -ffast-math -funroll-loops -O3 -std=c

Re: KDNSSD merge

On 26/02/14 10:01, Alex Merry wrote: > Actually, having slept on it, my suggestion is: > > - rename kdnssd to zeroconf-ioslave > - rename kdnssd-framework to kdnssd > - merge the frameworks branch of zeroconf-ioslave into kio I don't think the last part is necessarily a blocker, either (although

Review Request 116080: find_dependency: Update to match CMake's version

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116080/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Re: KDE 5 versioning in documentation

On Wed, Feb 26, 2014 at 9:26 AM, Mario Fux KDE ML wrote: > > Dolphin for Plasma shouldn't be used as well, if I see it correctly, as > Dolphin work on Gnome, razorqt and Co as well and not just on Plasma. So > just > "Dolphin" or "Dolphin by KDE". Plus what Luigi wrote! > Yup, that makes perfect

Review Request 116079: Be more explicit with QFile include

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116079/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 116056: Port to Qt5 and Kf5 of dnssd ioslave and kded module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116056/#review50915 --- Argh, sorry, I completely missed this review request, and just

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

> On Feb. 26, 2014, 9:12 a.m., David Gil Oliva wrote: > > src/kdecore/kurl.h, line 386 > > > > > > I would say: > > > > @deprecated since 5.0, use Foo instead. > > > > I'm not sure how useful that

Re: KDNSSD merge

On 26/02/14 07:09, Kevin Ottens wrote: > On Tuesday 25 February 2014 20:37:28 Alex Merry wrote: >> I've had a look at the kdnssd repositoy, and it contains two related >> bits of code: the zeroconf ioslave and a kded/KDirWatch module to notify >> KIO about changes to available services. >> >> These

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50910 --- +1 from me - Marco Martin On Feb. 26, 2014, 8:09 a.m., Mart

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50911 --- +1 from me - Marco Martin On Feb. 26, 2014, 8:09 a.m., Mart

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50909 --- src/platformtheme/kdeplatformsystemtrayicon.h

Re: KDE 5 versioning in documentation

Am Dienstag, 25. Februar 2014, 22.47:51 schrieb Martin Klapetek: > Hey, Morning [snip] > > Will the "KDE Software Compilation" still be a thing in the KF5 era, > > complete with its own versioned releases? If that's the case, we'll > > probably just want to change "KDE" to "KDE SC" in the > >

Re: Review Request 116064: @deprecated docs for KUrl methods that duplicate QUrl methods

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116064/#review50906 --- src/kdecore/kurl.h

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50904 --- src/platformtheme/kdeplatformsystemtrayicon.cpp

Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: f