----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: libnm-qt Description ------- When I build libnm-qt on my openSuSE 64bit system libnm-qt ends up installing into $prefix/lib instead of $prefix/lib64. I know this can be fixed using -DLIB_SUFFIX=64, but KDEInstallDirs already handles this so why not use it. E-C-M is already required, so that is no problem. Not sure however whether it is okay to use one of the KDE modules for libnm-qt. If not I will update this request to use GNUInstallDirs which also handles the openSuSE case. Not sure who is responsible for the qt5 branch, so I just added kdeframeworks as reviewers. Diffs ----- CMakeLists.txt 9918278 NetworkManagerQt.pc.cmake 2c3ab07 Diff: https://git.reviewboard.kde.org/r/116098/diff/ Testing ------- Installed into the right directories after applying the patch. grep -irn LIB_SUFFIX * returns nothing Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
