----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115984/#review50984 -----------------------------------------------------------
This review has been submitted with commit 3698faa2c1f2164a28e754b4defe8edbc68b774b by David Gil to branch master. - Commit Hook On Feb. 24, 2014, 12:06 a.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115984/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 12:06 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Implement the d-pointer in KCompletionBase as in the other classes > > Add two methods: setEmitSignals(bool) and setKeybindingsMap(KeyBindingMap) > to be called from setDelegate(). Otherwise, it doesn't seem plausible > to reach the private member variables like this (the compiler complains): > > delegate->d->emitsRotationSignals = d->emitsRotationSignals; > > Now that has become: > > delegate->setEmitSignals(d->emitsRotationSignals); > > For coherence, implement the QScopedPointer and the init() method. > > > Diffs > ----- > > src/kcompletionbase.h 105a6d0 > src/kcompletionbase.cpp 66f9398 > > Diff: https://git.reviewboard.kde.org/r/115984/diff/ > > > Testing > ------- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
