> On Feb. 26, 2014, 9:57 p.m., Albert Astals Cid wrote: > > have you tried removing the include? > > Albert Astals Cid wrote: > Ignore me, there's i18n calls in there :D
However, I wonder if those calls should really be in the header. I have no idea what catalogue they will use at runtime; I suspect it will depend on whether code that includes the header defined TRANSLATION_DOMAIN and where, exactly, they do so. A better solution (SC but not BC) is probably to create overloaded methods and put those calls in the cpp file. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116103/#review50988 ----------------------------------------------------------- On Feb. 26, 2014, 9:44 p.m., Matthieu Gallien wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116103/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 9:44 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > include/KF5/KIOCore/kio/slavebase.h is including headers from KI18N and is > publically installed. > > > Diffs > ----- > > KF5KIOConfig.cmake.in 3a947b7 > src/core/CMakeLists.txt d897e37 > > Diff: https://git.reviewboard.kde.org/r/116103/diff/ > > > Testing > ------- > > > Thanks, > > Matthieu Gallien > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
