Build failed in Jenkins: kde4support_master_qt5 #35

2014-01-24 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 605 lines...] Generating moc_kfiletreeview_p.cpp Generating moc_kmetaprops.cpp Generating moc_k3bufferedsocket.cpp

Jenkins build is back to stable : ktexteditor_master_qt5 #150

2014-01-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Tier status of attica & kwallet

2014-01-24 Thread Valentin Rusu
On Friday, January 24, 2014 07:22:22 AM Kevin Ottens wrote: > On Thursday 23 January 2014 22:47:45 Valentin Rusu wrote: > > On Wednesday, January 22, 2014 10:48:00 PM Kevin Ottens wrote: > > > On Wednesday 22 January 2014 22:21:47 Valentin Rusu wrote: > > > > On Thursday, January 23, 2014 04:24:37

Jenkins build became unstable: ktexteditor_master_qt5 #149

2014-01-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115164: Keep tests together

2014-01-24 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48248 --- Ship it! Looks good to me. - Valentin Rusu On Jan. 22, 201

Build failed in Jenkins: kde4support_master_qt5 #34

2014-01-24 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 631 lines...] Generating moc_krestrictedline.cpp Generating moc_ksplashscreen.cpp Generating moc_kstatusbar.cpp Ge

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48246 --- cmake/FindLibIntl.cmake

Jenkins build is back to stable : ktexteditor_master_qt5 #146

2014-01-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Tier status of attica & kwallet

2014-01-24 Thread Valentin Rusu
On Saturday, January 25, 2014 01:49:51 AM Michael Palimaka wrote: > On 01/24/2014 09:21 AM, Alex Merry wrote: > > On 23/01/14 21:50, Valentin Rusu wrote: > >> On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: > >>> On 01/23/2014 08:21 AM, Valentin Rusu wrote: > On Thursday, Jan

Re: Review Request 115218: rename dbus interface file on install for kwallet

2014-01-24 Thread Valentin Rusu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115218/#review48242 --- Ship it! Ship It! - Valentin Rusu On Jan. 22, 2014, 11:23

Jenkins build became unstable: ktexteditor_master_qt5 #144

2014-01-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread šumski
On Friday 24 of January 2014 09:53:00 Ben Cooksley wrote: > There has been no changes in regards to the compiler, etc. on > build.kde.org in the past few weeks. > The only thing that could have changed would be the version of CMake - > as we follow the 'next' branch, so this could be a CMake regres

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread David Narvaez
On Fri, Jan 24, 2014 at 7:37 AM, Aleix Pol wrote: > I recreated my build directories and now I'm hitting it too. I guess it a > matter of time that it spreads to the rest of who are building > kde4support... > > I tried with cmake 2.8.12.1 and today's master. I'm on this, will provide my findings

Re: Review Request 115293: Statusbar: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/ --- (Updated Jan. 24, 2014, 4:28 p.m.) Status -- This change has been ma

Review Request 115300: Fix KKeySequence shortcut types flags

2014-01-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115300/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 115293: Statusbar: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/#review48231 --- Ship it! It is ok that way, perhaps I shall set an empty icon

Re: Review Request 115293: Statusbar: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/ --- (Updated Jan. 24, 2014, 4:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- (Updated Jan. 24, 2014, 5:06 p.m.) Review request for KDE Frameworks and

Re: Review Request 115293: Statusbar: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/ --- (Updated Jan. 24, 2014, 3:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alexander Richardson
> On Jan. 24, 2014, 2:04 p.m., Alex Merry wrote: > > CMakeLists.txt, line 47 > > > > > > Oh, also, should this be something like (WIN32) or (WIN32 AND NOT > > CYGWIN)? > > > > (Is WIN32 defined under CYG

Re: Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

2014-01-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115268/#review48223 --- Looks good to me. Once this is committed I will try to make su

Re: Review Request 115293: Statusbar: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/ --- (Updated Jan. 24, 2014, 3:12 p.m.) Review request for KDE Frameworks and

Re: Tier status of attica & kwallet

2014-01-24 Thread Michael Palimaka
On 01/24/2014 09:21 AM, Alex Merry wrote: > On 23/01/14 21:50, Valentin Rusu wrote: >> On Thursday, January 23, 2014 11:18:02 PM Michael Palimaka wrote: >>> On 01/23/2014 08:21 AM, Valentin Rusu wrote: On Thursday, January 23, 2014 04:24:37 AM Michael Palimaka wrote: >>> Sure, the framework it

Review Request 115294: Add system API feature macros to CMAKE_REQUIRED_DEFINES

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115294/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.

Review Request 115295: Do not set CMAKE_REQUIRED_DEFINES

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115295/ --- Review request for KDE Frameworks. Repository: kjs Description ---

Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115296/ --- Review request for KDE Frameworks. Repository: kde4support Description

Re: Review Request 115293: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/ --- (Updated Jan. 24, 2014, 2:41 p.m.) Review request for KDE Frameworks, Chr

Review Request 115293: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/ --- Review request for KDE Frameworks, Christoph Cullmann and Dominik Haumann.

Re: Review Request 115293: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115293/ --- (Updated Jan. 24, 2014, 2:40 p.m.) Review request for KDE Frameworks, Chr

Re: Review Request 115292: Do Configure Checks in the Correct Language

2014-01-24 Thread Alex Merry
> On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 20 > > > > > > This is the underlying cause of the issue. I think the reason your > > changes fix it is the same reason removi

Re: Review Request 115292: Do Configure Checks in the Correct Language

2014-01-24 Thread Alex Merry
> On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 20 > > > > > > This is the underlying cause of the issue. I think the reason your > > changes fix it is the same reason removi

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Alex Merry
On 24/01/14 14:15, Christoph Cullmann wrote: > Hmm, see > > https://git.reviewboard.kde.org/r/115292/ > > that fixes it for me ;) Yeah, but it fixes it somewhat "by accident". Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org ht

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Christoph Cullmann
Hmm, see https://git.reviewboard.kde.org/r/115292/ that fixes it for me ;) - Ursprüngliche Mail - > On 24/01/14 13:30, Alex Merry wrote: > > On 24/01/14 13:22, Christoph Cullmann wrote: > >>> I recreated my build directories and now I'm hitting it too. I guess it a > >>> matter of time t

Re: Review Request 115292: Do Configure Checks in the Correct Language

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48219 --- src/ConfigureChecks.cmake

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Alex Merry
On 24/01/14 13:30, Alex Merry wrote: > On 24/01/14 13:22, Christoph Cullmann wrote: >>> I recreated my build directories and now I'm hitting it too. I guess it a >>> matter of time that it spreads to the rest of who are building >>> kde4support... >>> >>> I tried with cmake 2.8.12.1 and today's mas

Re: Review Request 115292: Do Configure Checks in the Correct Language

2014-01-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48216 --- Patch fixes the issue for me here, think perhaps the same is n

Review Request 115292: Do Configure Checks in the Correct Language

2014-01-24 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/ --- Review request for KDE Frameworks and Alex Merry. Repository: kde4support

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Alex Merry
On 24/01/14 13:22, Christoph Cullmann wrote: >> I recreated my build directories and now I'm hitting it too. I guess it a >> matter of time that it spreads to the rest of who are building >> kde4support... >> >> I tried with cmake 2.8.12.1 and today's master. > It seems to be this change: > > http

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Christoph Cullmann
> I recreated my build directories and now I'm hitting it too. I guess it a > matter of time that it spreads to the rest of who are building > kde4support... > > I tried with cmake 2.8.12.1 and today's master. It seems to be this change: https://projects.kde.org/projects/kdesupport/extra-cmake-mo

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48204 --- CMakeLists.txt

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48203 --- CMakeLists.txt

Re: Review Request 115225: Add runtime platform support to KWindowInfo

2014-01-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/#review48200 --- Looks good to me, however I think someone else should give the

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Aleix Pol
On Fri, Jan 24, 2014 at 3:20 AM, Ben Cooksley wrote: > On Fri, Jan 24, 2014 at 1:28 PM, šumski wrote: > > On Friday 24 of January 2014 09:53:00 Ben Cooksley wrote: > >> There has been no changes in regards to the compiler, etc. on > >> build.kde.org in the past few weeks. > >> The only thing tha

Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

2014-01-24 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Re: Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

2014-01-24 Thread Martin Gräßlin
> On Jan. 24, 2014, 10:42 a.m., Hugo Pereira Da Costa wrote: > > I guess, you will delete the oxygen implementation when this is done, right > > ? > > (for the record, I had some implementation detail comments about it. Guess > > I might have missed the review, or read not carefully enough) >

Re: Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

2014-01-24 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115285/#review48180 --- I guess, you will delete the oxygen implementation when this i

Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

2014-01-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115285/ --- Review request for KDE Frameworks and Hugo Pereira Da Costa. Repository:

Re: KIO::convertSize(.,.) vs. KFormat::formatByteSize(...)

2014-01-24 Thread David Faure
On Thursday 23 January 2014 23:43:36 Friedrich W. H. Kossebau wrote: > Hi, > > I see a few overlappings between methods in KFormat (KCoreAddons) and KIO > (KIOCore), mainly this pair: > > namespace KIO > { > typedef qulonglong filesize_t; > KIOCORE_EXPORT QString convertSize(KIO::filesize_t size)

Re: Review Request 115225: Add runtime platform support to KWindowInfo

2014-01-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115225/ --- (Updated Jan. 24, 2014, 9:04 a.m.) Review request for KDE Frameworks and