----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115289/#review48246 -----------------------------------------------------------
cmake/FindLibIntl.cmake <https://git.reviewboard.kde.org/r/115289/#comment34144> Why not check if a libintl symbol exists without linking against any special libraries? - Alex Merry On Jan. 24, 2014, 4:06 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115289/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 4:06 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > MSVC fix: Check for libintl.h and libintl.lib > > On MSVC we have libintl as a separate library and must therefore explicitly > link to it. This is not required on linux since gettext is part of glibc. > On Windows libintl.h is not always found in the default include path and > has to be searched for. > > Fix linking on MSVC by using KTRANSCRIPT_EXPORT > > > Diffs > ----- > > src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e > src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 > src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 > src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 > cmake/FindLibIntl.cmake PRE-CREATION > CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c > > Diff: https://git.reviewboard.kde.org/r/115289/diff/ > > > Testing > ------- > > Compiles on Windows, no change to Linux > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
