> On Jan. 24, 2014, 2:17 p.m., Alex Merry wrote: > > src/ConfigureChecks.cmake, line 20 > > <https://git.reviewboard.kde.org/r/115292/diff/1/?file=240431#file240431line20> > > > > This is the underlying cause of the issue. I think the reason your > > changes fix it is the same reason removing the -std=iso9899:1990 fixes it; > > GCC auto-enables various bits of functionality based on the -std variable, > > and the one for CXX is -std=c++0x. > > Alex Merry wrote: > I'm just compile-checking my own fix for this, btw.
Oh, but that doesn't mean you should discard your changes. If these features are used from C++ code, they should be checked in C++ code. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48219 ----------------------------------------------------------- On Jan. 24, 2014, 1:55 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115292/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 1:55 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kde4support > > > Description > ------- > > A recent change in ECM revealed an issue with ConfigureChecks.cmake, where > the check_symbol_exist calls would use the C compiler (with CFLAGS) and the > compilation would happen in C++ (with CXXFLAGS). This change ports all checks > to CXX where possible. > > > Diffs > ----- > > src/ConfigureChecks.cmake 7c8951f > > Diff: https://git.reviewboard.kde.org/r/115292/diff/ > > > Testing > ------- > > 1. Refreshed builds for ECM and KDE4Support, both building OK > 2. $ grep HAVE_GETADDRINFO src/config-network.h > #define HAVE_GETADDRINFO 1 > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
