----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115285/#review48180 -----------------------------------------------------------
I guess, you will delete the oxygen implementation when this is done, right ? (for the record, I had some implementation detail comments about it. Guess I might have missed the review, or read not carefully enough) - Hugo Pereira Da Costa On Jan. 24, 2014, 9:36 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115285/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 9:36 a.m.) > > > Review request for KDE Frameworks and Hugo Pereira Da Costa. > > > Repository: frameworkintegration > > > Description > ------- > > Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows > > This feature is upstreamed from the Oxygen style. It is a general > feature for integration with our window manager and thus should be in > the generic style implementation and not just in Oxygen. > > So far the implementation only supports X11 and installs an X property > on all toplevel windows. On other platforms it is currently a no-op. > > This introduces an optional dependency on XCB and QtX11Extras. If they > are not found the feature is obviously not compiled. > > > Diffs > ----- > > src/kstyle/CMakeLists.txt 41c92c266a92e4e3534114c982ed98cf529456d5 > src/kstyle/kstyle.cpp f79675b85a58d0f132bc3d336996d51a2661e567 > > Diff: https://git.reviewboard.kde.org/r/115285/diff/ > > > Testing > ------- > > Tested with the kcolorschemedemo in kconfigwidgets/tests and an adjusted > Oxygen without the feature. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
