Use of the WIN32 executable property

[Background for the blissfully Windows-ignorant devs: On Windows, executable files have a flag saying whether they are GUI or console applications. Running a GUI application from a console will give you the prompt back immediately; I think there's no way to capture stdout. Running a console applica

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1324

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1323

See Changes: [aleixpol] Fix build -- [...truncated 511 lines...] -- KF5[InstallDirs]: Loaded settings from /srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/extra-cmake-modules/master/share

Re: Review Request 113067: Fix compilation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113067/ --- (Updated Oct. 2, 2013, 9:48 p.m.) Status -- This change has been disc

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112985/ --- (Updated Oct. 2, 2013, 9:33 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113067: Fix compilation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113067/#review41148 --- Ship it! This is the simplest solution to get it back building

Review Request 113067: Fix compilation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113067/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Build failed in Jenkins: kdelibs_frameworks_qt5 #1322

See Changes: [kde] Make leftMargin rightMargin virtual methods in KCategoryDrawer [kde] Set correct target for KEmoticons export -- [...truncated 510 lines...] -- Looking for openpty in util -

Re: Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112923/#review41145 --- This review has been submitted with commit d58a96548bf5af03529

Re: Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112923/ --- (Updated Oct. 2, 2013, 7:12 p.m.) Status -- This change has been mark

Re: Review Request 113008: Clean up KWallet before moving to its own tier

> On Oct. 2, 2013, 6:51 p.m., Valentin Rusu wrote: > > Ship It! Thanks for doing this! - Valentin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#review41142 -

Re: Review Request 113008: Clean up KWallet before moving to its own tier

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113008/#review41142 --- Ship it! Ship It! - Valentin Rusu On Oct. 2, 2013, 12:53 a.

Re: Review Request 113039: Remove unused includes from KDESu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/#review41141 --- Ship it! Woa amazing :) +1 - Aleix Pol Gonzalez On Oct. 1,

Re: Switch build.kde.org to Qt stable branch

On Wed, Oct 2, 2013 at 7:53 PM, Nicolás Alvarez wrote: > As you may know, Qt is working to release 5.2. The dev branch has been > merged to the stable branch, which means the stable branch is now 5.2, > and dev is now 5.3. > > build.kde.org is compiling Qt from source, but it's using the dev > bra

Re: Review Request 113039: Remove unused includes from KDESu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113039/#review41138 --- Ship it! Ship It! - David Edmundson On Oct. 1, 2013, 9:12 p

Switch build.kde.org to Qt stable branch

As you may know, Qt is working to release 5.2. The dev branch has been merged to the stable branch, which means the stable branch is now 5.2, and dev is now 5.3. build.kde.org is compiling Qt from source, but it's using the dev branch. As far as I know, the plan is to release KF5 depending on Qt 5

Build failed in Jenkins: kdelibs_frameworks_qt5 #1321

See Changes: [aleixpol] kio also uses finders from cmake/modules -- [...truncated 507 lines...] -- Looking for openpty in util - found -- Looking for ptsname -- Looking for ptsname - found --

Build failed in Jenkins: kdelibs_frameworks_qt5 #1320

See Changes: [aleixpol] kioslaves also uses finders from cmake/modules -- [...truncated 522 lines...] CMake Warning at kio/CMakeLists.txt:40 (find_package): By not providing "FindACL.cmake"

Build failed in Jenkins: kdelibs_frameworks_qt5 #1319

See Changes: [aleixpol] Fix build [aleixpol] Should have gone in -- [...truncated 541 lines...] -- Looking for include file arpa/nameser8_compat.h - not found -- Looking for include files sys/

Re: Review Request 112901: Remove weird cmake indirections

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/#review41133 --- This review has been submitted with commit fcd2f0fa8f8e5c3228c

Re: Review Request 112901: Remove weird cmake indirections

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112901/ --- (Updated Oct. 2, 2013, 5:17 p.m.) Status -- This change has been mark

Build failed in Jenkins: kdelibs_frameworks_qt5 #1318

See Changes: [aleixpol] Remove weird cmake indirections -- [...truncated 614 lines...] -- Looking for include files sys/types.h, netinet/in.h - found -- Looking for res_init in resolv -- Lookin

Re: Review Request 112828: Add a new functions to add unit tests

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/ --- (Updated Oct. 2, 2013, 7:14 p.m.) Review request for Extra Cmake Modules a

Build failed in Jenkins: kdelibs_frameworks_qt5 #1317

See Changes: [aleixpol] Make sure all modules in tier3 are finding all packages [aleixpol] Make sure all modules in tier2 are finding all packages [aleixpol] Make sure all modules in tier1 are finding all packages [aleixpol] Make s

Re: Review Request 113052: Remove find_package calls from root kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/#review41131 --- This review has been submitted with commit ca62212ab2a68e71616

Re: Review Request 113052: Remove find_package calls from root kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 5:07 p.m.) Status -- This change has been mark

Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/#review41129 --- This review has been submitted with commit af042fc83959374aa6a

Build failed in Jenkins: kdelibs_frameworks_qt5 #1314

See Changes: [mklapetek] Move kdesu to staging [mklapetek] Adopt framework's standard dir scheme for KDESu -- [...truncated 16937 lines...] In file included from

Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/ --- (Updated Oct. 2, 2013, 4:09 p.m.) Status -- This change has been mark

Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/#review41130 --- This review has been submitted with commit 75d32589a379415e951

Re: Review Request 112942: Move KDNSSD to tier2

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112942/ --- (Updated Oct. 2, 2013, 4:05 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 113052: Remove find_package calls from root kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/#review41128 --- Ship it! Ship It! - Stephen Kelly On Oct. 2, 2013, 3:54 p.m

Re: Review Request 113052: Remove find_package calls from root kdelibs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113052/ --- (Updated Oct. 2, 2013, 3:54 p.m.) Review request for KDE Frameworks and St

Re: Review Request 113049: Fix libAttica build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/ --- (Updated Oct. 2, 2013, 3:29 p.m.) Status -- This change has been mark

Re: Review Request 113049: Fix libAttica build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/#review41126 --- This review has been submitted with commit a84850ffea8d8dc9bb6

Re: Review Request 113050: Use enum for KMessageBox return types

> On Oct. 2, 2013, 4:47 p.m., Aleix Pol Gonzalez wrote: > > I like the idea of being more specific about the return value, but isn't > > this going to break source compatibility? No because it is OK to assign an enum to an int, so this code: int result = KMessageBox::warningContinueCancel(

Re: KMessageBox return values

On Wednesday 02 October 2013 15:39:20 Aurélien Gâteau wrote: > Hi, > > Working on KMessageBox namespace, I noticed all methods returns int, despite > the namespace declaring a ButtonCode enum. I gave a try at changing the > type of the return values to KMessageBox::ButtonCode. This would bring > b

Re: Review Request 113050: Use enum for KMessageBox return types

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/#review41120 --- I like the idea of being more specific about the return value,

Review Request 113050: Use enum for KMessageBox return types

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113050/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113049: Fix libAttica build

> On Oct. 2, 2013, 2:20 p.m., Stephen Kelly wrote: > > Does this make attica independent of ECM? Does it still need to find ECM? Actually yes. So I'll remove the find_package(ECM...) too and push. - Martin --- This is an automatically g

Re: Review Request 113049: Fix libAttica build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/#review41117 --- Ship it! Does this make attica independent of ECM? Does it sti

Review Request 113049: Fix libAttica build

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113049/ --- Review request for Attica and KDE Frameworks. Repository: attica Descrip

KMessageBox return values

Hi, Working on KMessageBox namespace, I noticed all methods returns int, despite the namespace declaring a ButtonCode enum. I gave a try at changing the type of the return values to KMessageBox::ButtonCode. This would bring better type safety, is still source-compatible (existing code which use

Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113038/#review41115 --- Ship it! kdesu/CMakeLists.txt

Re: Review Request 113046: Move kconfigwidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/ --- (Updated Oct. 2, 2013, 1:19 p.m.) Status -- This change has been mark

Re: Review Request 113046: Move kconfigwidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/#review41114 --- This review has been submitted with commit a0a0920fe3731cd7803

Re: Review Request 113046: Move kconfigwidgets to tier3

On Wednesday, October 02, 2013 11:09:59 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Move kconfigwidgets to tier3 > > > > > > When I suggested tiers, I proposed that tier2 frameworks could depend on > other tier2 frameworks. > > http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focu

Re: Review Request 113046: Move kconfigwidgets to tier3

On Wednesday 02 October 2013 14:48:45 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote: > >> Aurélien Gâteau wrote: > >> > I don't have any strong opinion on this, but if we allow tier2 > >> > frameworks to depend on other tier2 frameworks

Re: Review Request 113046: Move kconfigwidgets to tier3

Aurélien Gâteau wrote: > On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote: >> Aurélien Gâteau wrote: >> > I don't have any strong opinion on this, but if we allow tier2 >> > frameworks to depend on other tier2 frameworks then is there a need for >> > tier3 at all? Your wiki pages seems to

Re: Review Request 113046: Move kconfigwidgets to tier3

On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > I don't have any strong opinion on this, but if we allow tier2 frameworks > > to depend on other tier2 frameworks then is there a need for tier3 at all? > > Your wiki pages seems to indicate there is no need for

Re: [Review Request] Modularizing KF5

Aleix Pol wrote: > I pushed a couple of new commits that remove the usage of macro_bool_to_01 > and the HAVE_QSSLSOCKET thing. > I assume you have no intention of merging that branch? The top commit looks fine at least. Please cherry-pick it to frameworks, and rebase and clean-up the rest of

Re: Review Request 113045: Prepare KCMUtils for move to tier3

David Edmundson wrote: > I haven't moved anything. > > Also this review is 3 different commits, one for each of the sentences > in the description. Indeed, thanks! Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mai

Re: [Review Request] Modularizing KF5

On Wed, Oct 2, 2013 at 10:25 AM, Stephen Kelly wrote: > Aurélien Gâteau wrote: > > > On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: > >> Hi, > >> Since ReviewBoard is not working for me, I decided to send this review > as > >> an e-mail. I know it's less practical, but also I think it's imp

Re: Review Request 113045: Prepare KCMUtils for move to tier3

I haven't moved anything. Also this review is 3 different commits, one for each of the sentences in the description. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113045: Prepare KCMUtils for move to tier3

David Edmundson wrote: > > >> On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote: >> > staging/kcmutils/CMakeLists.txt, line 23 >> > >> > >> > Why removing these? > > As I understand it everything should comp

Re: Review Request 113045: Prepare KCMUtils for move to tier3

> On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote: > > staging/kcmutils/CMakeLists.txt, line 23 > > > > > > Why removing these? As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was

Re: Review Request 113048: Move KPrintUtils to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/#review41112 --- This review has been submitted with commit 51d842f411194d22ff8

Re: Review Request 113048: Move KPrintUtils to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- (Updated Oct. 2, 2013, 11:48 a.m.) Status -- This change has been mar

Re: Review Request 113046: Move kconfigwidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/#review41109 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 2, 2013, 8:3

Re: Review Request 113048: Move KPrintUtils to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/#review41108 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 2, 2013, 10:

Re: Review Request 112828: Provide ecm_add_unit_test() and ecm_add_multiple_unit_tests()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112828/#review41107 --- ping, Richardson can you comment over this review? we really ne

Re: Review Request 113045: Prepare KCMUtils for move to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/#review41105 --- staging/kcmutils/CMakeLists.txt

Re: Review Request 113048: Move KPrintUtils to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- (Updated Oct. 2, 2013, 10:29 a.m.) Review request for KDE Frameworks. Re

Review Request 113048: Move KPrintUtils to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113048/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 113046: Move kconfigwidgets to tier3

Aurélien Gâteau wrote: > I don't have any strong opinion on this, but if we allow tier2 frameworks > to depend on other tier2 frameworks then is there a need for tier3 at all? > Your wiki pages seems to indicate there is no need for it. > That wiki page predates the Randa meeting, where some stu

Re: Review Request 112998: Add a simple app to test KPrintPreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/#review41101 --- This review has been submitted with commit 0110e8148a52c88fba9

Re: Review Request 112998: Add a simple app to test KPrintPreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/ --- (Updated Oct. 2, 2013, 9:36 a.m.) Status -- This change has been mark

Re: Review Request 112998: Add a simple app to test KPrintPreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/#review41100 --- Ship it! Ship It! - Aurélien Gâteau On Oct. 2, 2013, 11:27

Re: Review Request 113046: Move kconfigwidgets to tier3

On Wednesday 02 October 2013 11:09:59 Stephen Kelly wrote: > Aurélien Gâteau wrote: > > Move kconfigwidgets to tier3 > > When I suggested tiers, I proposed that tier2 frameworks could depend on > other tier2 frameworks. > > http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520 > h

Re: Review Request 112998: Add a simple app to test KPrintPreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/ --- (Updated Oct. 2, 2013, 9:27 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 112998: Add a simple app to test KPrintPreview

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/#review41099 --- the add_subdirectory(tests) is still commented in staging/kpri

Re: Review Request 113046: Move kconfigwidgets to tier3

Aurélien Gâteau wrote: > Move kconfigwidgets to tier3 > When I suggested tiers, I proposed that tier2 frameworks could depend on other tier2 frameworks. http://thread.gmane.org/gmane.comp.kde.devel.core/67458/focus=67520 http://techbase.kde.org/index.php?title=Projects/KDELibsModifications&

Re: Review Request 112931: Prepare kconfigwidgets for tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112931/ --- (Updated Oct. 2, 2013, 10:33 a.m.) Status -- This change has been mar

Review Request 113046: Move kconfigwidgets to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113046/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: [Review Request] Modularizing KF5

Aurélien Gâteau wrote: > On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: >> Hi, >> Since ReviewBoard is not working for me, I decided to send this review as >> an e-mail. I know it's less practical, but also I think it's important to >> get it done and I'd rather go reasonably fast with it be

Re: [Review Request] Modularizing KF5

On Wednesday 02 October 2013 10:14:12 Aurélien Gâteau wrote: > On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: > > Hi, > > Since ReviewBoard is not working for me, I decided to send this review as > > an e-mail. I know it's less practical, but also I think it's important to > > get it done and

Re: [Review Request] Modularizing KF5

On Tuesday 01 October 2013 19:28:04 Aleix Pol wrote: > Hi, > Since ReviewBoard is not working for me, I decided to send this review as > an e-mail. I know it's less practical, but also I think it's important to > get it done and I'd rather go reasonably fast with it before we start > getting too mu

Review Request 113045: Prepare KCMUtils for move to tier3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: kcmutils linking issues

Hello, > And what's the error message? > > -- > David Faure, fa...@kde.org, http://www.davidfaure.fr > Working on KDE, in particular KDE Frameworks 5 > > After his patch , the issue has been fixed by itself... I can no more