----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112998/#review41099 -----------------------------------------------------------
the add_subdirectory(tests) is still commented in staging/kprintutils/CMakeLists.txt. Just uncommented it to test, the test app does not do much yet, but it does what you said :) I'd say ship it once the add_subdirectory() call is uncommented and the indent is fixed. staging/kprintutils/tests/CMakeLists.txt <http://git.reviewboard.kde.org/r/112998/#comment30166> nitpick: 2-spaces indent is more common in kdelibs CMake files. - Aurélien Gâteau On Oct. 1, 2013, 10:06 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112998/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2013, 10:06 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Simple app testing KPrintPreview. However there's no suitable pdf KPart right > now so at this point it tests the case of missing such KPart. Which is also > good. It will work as expected once such KPart exists. > > > Diffs > ----- > > staging/kprintutils/tests/CMakeLists.txt PRE-CREATION > staging/kprintutils/tests/kprintpreview_test.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112998/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
