> On Oct. 2, 2013, 11:02 a.m., Aleix Pol Gonzalez wrote:
> > staging/kcmutils/CMakeLists.txt, line 23
> > <http://git.reviewboard.kde.org/r/113045/diff/1/?file=193397#file193397line23>
> >
> > Why removing these?
As I understand it everything should compile with -DQT_NO_CAST_TO_ASCII, it was
previously added here to make it compile before all the "blah" ->
QLiteralString("blah") changes.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41105
-----------------------------------------------------------
On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113045/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2013, 8:06 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Only find publicly used libraries in cmake.in
>
>
> KCategoryDrawer -> KCategoryDrawerV3
>
>
> No QString cast from ascii
>
>
> Diffs
> -----
>
> staging/kcmutils/CMakeLists.txt dc577d3
> staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52
> staging/kcmutils/src/CMakeLists.txt dc19649
> staging/kcmutils/src/kcmodulecontainer.cpp c08eda2
> staging/kcmutils/src/kcmoduleinfo.cpp f46308c
> staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab
> staging/kcmutils/src/kcmultidialog.cpp 4812407
> staging/kcmutils/src/kpluginselector.cpp 77cbfda
> staging/kcmutils/src/kpluginselector_p.h 2dffae0
> staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a
> staging/kcmutils/src/ksettings/dialog.cpp 131f75f
> staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc
> staging/kcmutils/src/ksettings/pluginpage.cpp 0577908
>
> Diff: http://git.reviewboard.kde.org/r/113045/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
