----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113067/#review41148 -----------------------------------------------------------
Ship it! This is the simplest solution to get it back building. Go for it. - Nicolás Alvarez On Oct. 2, 2013, 9:12 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113067/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 9:12 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Partially revert ca62212ab2a68e716167f08f2433fe735dcba302 > > By removing find_package(KF5 InstallDirs) ${LIB_INSTALL_DIR} does > not expand causing kdelibsLibraryTargets to be installed to try > and install to the root directory /cmake/ which causes compile errors. > > We cannot remove kdelibsLibraryTargets until each library can install itself > > see http://build.kde.org/job/kdelibs_frameworks_qt5/1317/console > > > Diffs > ----- > > CMakeLists.txt cdc3120 > > Diff: http://git.reviewboard.kde.org/r/113067/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
