Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/ --- Review request for Baloo. Repository: baloo Description --- This c

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/#review63907 --- src/CMakeLists.txt

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas
> On Aug. 6, 2014, 11:04 a.m., Vishesh Handa wrote: > > src/imports/CMakeLists.txt, line 11 > > > > > > This is not required. No it is required, otherwise we cannot link our engine. - Antonis

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/ --- (Updated Aug. 6, 2014, 12:02 p.m.) Review request for Baloo. Changes --

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/#review63918 --- Looks good otherwise! CMakeLists.txt

Re: Review Request 118438: Add an option to only build baloo's libraries

2014-08-06 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118438/ --- (Updated Aug. 6, 2014, 2:31 p.m.) Status -- This change has been mar

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/ --- (Updated Aug. 6, 2014, 2:51 p.m.) Review request for Baloo. Repository:

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/#review63924 --- Ship it! Once you've made the changes feel free to ship it.

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/ --- (Updated Aug. 6, 2014, 4:37 p.m.) Status -- This change has been mar

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/#review63938 --- looks like this went into wrong branch? i.e. frameworks instea

[ANNOUNCE] CMake 3.0.1 Released

2014-08-06 Thread Robert Maynard
We are pleased to announce that CMake 3.0.1 is now available for download. The change log page for this bug-fix only release is here: http://public.kitware.com/Bug/roadmap_page.php?version_id=123 Please use the latest release from our download page: http://cmake.org/cmake/resources/software.ht

Re: Review Request 119631: Baloo: Introduce org.kde.baloo component.

2014-08-06 Thread Vishesh Handa
> On Aug. 6, 2014, 4:48 p.m., Hrvoje Senjan wrote: > > looks like this went into wrong branch? i.e. frameworks instead of master Yup. Antonis please push this to the master branch. I've deleted the frameworks branch. - Vishesh --- Thi