-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118438/
-----------------------------------------------------------

(Updated Aug. 6, 2014, 2:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for Baloo.


Repository: baloo


Description
-------

The intention behind this review request is to make it easier to turn baloo 
into a framework and make it coinstallable with its KDE4 counterpart in a 
second review request.

That being said I'm not exactly sure this is the way you guys want to go, but 
I'd be willing to update my review request accordingly if you have other plans 
to make it coinstallable.


Diffs
-----

  CMakeLists.txt abb494ae32ef27e0ca65da341f5d9a0b37f51645 
  src/CMakeLists.txt 810f6dcd97b5f3ff64962709efbfffec7fa9a257 
  src/file/CMakeLists.txt 7d384c51662a0b381e6fc861e8565c6da4af8525 

Diff: https://git.reviewboard.kde.org/r/118438/diff/


Testing
-------

cmake -DBALOO_LIBRARIES_ONLY:BOOL=TRUE ..
make
make install

I've also built the frameworks branch of milou against it (needed a few 
modifications).


Thanks,

Heiko Becker

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Reply via email to