----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/#review63918 -----------------------------------------------------------
Looks good otherwise! CMakeLists.txt <https://git.reviewboard.kde.org/r/119631/#comment44587> I meant that this line can be combined with the previous one. find_package(Qt5 REQUIRED NO_MODULE COMPONENTS Widgets Dbus Test Sql Quick) src/qml/CMakeLists.txt <https://git.reviewboard.kde.org/r/119631/#comment44586> Minor nitpick. This isn't required. src/qml/baloodatamodel.cpp <https://git.reviewboard.kde.org/r/119631/#comment44589> I'm not sure if we need these 2 role names. They are typically defined by default. The correct way to implement this function would be - QHash<int, QByteArray> roles = QAbstractListModel::roleNames(); roles[IdRole] = "id"; roles[UrlRole] = "url"; reuturn roles; - Vishesh Handa On Aug. 6, 2014, 12:02 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119631/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 12:02 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > This component exports some of the basic API of the Baloo::Query into to QML. > > At the moment it supports only the Baloo::Query::setType and > Baloo::Query::setLimit, > with the following syntax. > > BalooModel { > query { > type: "File/Image" > limit: 10 > } > } > > > Diffs > ----- > > CMakeLists.txt abb494a > src/CMakeLists.txt 810f6dc > src/qml/CMakeLists.txt PRE-CREATION > src/qml/baloodatamodel.h PRE-CREATION > src/qml/baloodatamodel.cpp PRE-CREATION > src/qml/balooplugin.h PRE-CREATION > src/qml/balooplugin.cpp PRE-CREATION > src/qml/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119631/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
