----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119631/#review63924 -----------------------------------------------------------
Ship it! Once you've made the changes feel free to ship it. src/qml/baloodatamodel.cpp <https://git.reviewboard.kde.org/r/119631/#comment44602> If you feel like removing this line and the next it would be nice. Your choice. src/qml/baloodatamodel.cpp <https://git.reviewboard.kde.org/r/119631/#comment44603> I just realized that we're still leaking memory as the old m_query is just being ignored. Please call `delete m_query` before this line. - Vishesh Handa On Aug. 6, 2014, 2:51 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119631/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 2:51 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > This component exports some of the basic API of the Baloo::Query into to QML. > > At the moment it supports only the Baloo::Query::setType and > Baloo::Query::setLimit, > with the following syntax. > > BalooModel { > query { > type: "File/Image" > limit: 10 > } > } > > > Diffs > ----- > > src/qml/qmldir PRE-CREATION > CMakeLists.txt abb494a > src/CMakeLists.txt 810f6dc > src/qml/CMakeLists.txt PRE-CREATION > src/qml/baloodatamodel.h PRE-CREATION > src/qml/baloodatamodel.cpp PRE-CREATION > src/qml/balooplugin.h PRE-CREATION > src/qml/balooplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119631/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
