dajac opened a new pull request, #15883:
URL: https://github.com/apache/kafka/pull/15883
This PR is still WIP. I am still playing with an alternative approach.
Trunk:
```
Benchmark (assignmentType)
(assignorType) (isRackAware) (memberCoun
KevinZTW opened a new pull request, #15884:
URL: https://github.com/apache/kafka/pull/15884
Merge the unit test functions down to the class of integration test to avoid
two test class under the same file
### Committer Checklist (excluded from commit message)
- [ ] Verify design
chia7712 commented on code in PR #15868:
URL: https://github.com/apache/kafka/pull/15868#discussion_r1592649000
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java:
##
@@ -115,11 +112,11 @@ public void ensureInternalEndpoin
FrankYang0529 commented on code in PR #15872:
URL: https://github.com/apache/kafka/pull/15872#discussion_r1592664550
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -88,7 +113,7 @@ public void testDeleteOf
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1592678706
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -392,6 +399,146 @@ protected Map
validateSourceConnectorConfig(SourceConn
FrankYang0529 commented on PR #15821:
URL: https://github.com/apache/kafka/pull/15821#issuecomment-2098714976
Hi @chia7712, I rebase latest trunk branch, so we have
`ConsumerGroupCommandTestUtils` now. The only remaining part is
`SimpleConsumerGroupExecutor`. This is used by `ListConsumerGr
gharris1727 commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1591293880
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -184,20 +146,34 @@ public void process(final Record record) {
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2098726331
Thanks @gharris1727. I've reverted the changes to `Utils.java` and verified
locally with tests. Everything else looked okay on the previous CI run, going
to merge.
--
This is an autom
jolshan commented on PR #15837:
URL: https://github.com/apache/kafka/pull/15837#issuecomment-2098727340
Sorry I was out of town (at KSB). I will try to take a look today, but
thanks Luke for approving as well :)
--
This is an automated message from the Apache Git Service.
To respond to t
C0urante merged PR #14309:
URL: https://github.com/apache/kafka/pull/14309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on code in PR #15868:
URL: https://github.com/apache/kafka/pull/15868#discussion_r1592697934
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java:
##
@@ -115,11 +112,11 @@ public void ensureInternalEn
FrankYang0529 commented on code in PR #15868:
URL: https://github.com/apache/kafka/pull/15868#discussion_r1592700292
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java:
##
@@ -115,11 +112,11 @@ public void ensureInternalEn
cadonna commented on code in PR #15408:
URL: https://github.com/apache/kafka/pull/15408#discussion_r1592700226
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala:
##
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
raminqaf commented on PR #15601:
URL: https://github.com/apache/kafka/pull/15601#issuecomment-2098817942
@gharris1727 Thanks for the feedback! I reverted all the changes you
requested and reverted a couple of other indentation problems that caused a
diff. I can even go further and revert &
viktorsomogyi commented on PR #15697:
URL: https://github.com/apache/kafka/pull/15697#issuecomment-2098821932
@soarez at the end I chose the shortcut regarding detecting leaders before
shutdown. The reason is complex as the solution that would be required for this
is complex too.
So on o
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1592759299
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,15 +148,19 @@ public Map>
perBrokerOverrideProperties() {
return perBrokerOverrideProperti
gaurav-narula opened a new pull request, #15885:
URL: https://github.com/apache/kafka/pull/15885
Some tests in TopicBasedRemoteLogMetadataManagerTest flake because
`waitUntilConsumerCatchesUp` may break early before consumer manager has caught
up with all the events.
This PR adds an
gaurav-narula commented on PR #15885:
URL: https://github.com/apache/kafka/pull/15885#issuecomment-2098848112
CC: @clolov @satishd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
johnnychhsu commented on PR #15861:
URL: https://github.com/apache/kafka/pull/15861#issuecomment-2098850247
@chia7712
> As https://github.com/apache/kafka/pull/15766 gets merged now, could you
please fix the build error?
sure, let me rebase the latest trunk and fix that since
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2098864822
@chia7712 , please take a look for this PR, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
m1a2st commented on PR #15840:
URL: https://github.com/apache/kafka/pull/15840#issuecomment-2098869565
@chia7712 , I have been add zookeeper `--bootstrap-server` tests, please
review, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please
soarez commented on PR #15836:
URL: https://github.com/apache/kafka/pull/15836#issuecomment-2098918354
`:core:test` timed out only on JDK 8 and Scala 2.12. Restarted the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
gaurav-narula commented on PR #15065:
URL: https://github.com/apache/kafka/pull/15065#issuecomment-2098952056
Bumping this thread for more visibility.
Would be nice if we give this a shot since we still run into builds which
[time
out](https://ci-builds.apache.org/blue/organizations/
C0urante commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1592838802
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1144,6 +1144,21 @@ public void putConnectorConfig(final Stri
C0urante commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1592847527
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java:
##
@@ -242,6 +242,19 @@ public Response putConnectorConfig(fina
junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1592859538
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,9 +414,7 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestampMs
C0urante commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -773,6 +773,41 @@ public void
testDeleteConnectorCreatedW
C0urante commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -773,6 +773,41 @@ public void
testDeleteConnectorCreatedW
C0urante commented on PR #6934:
URL: https://github.com/apache/kafka/pull/6934#issuecomment-2098991457
Thanks @ivanyu, this is really close. One other thing--can you update the
description with a brief overview of the PR (probably enough to just mention
the new endpoint and its behavior), a
C0urante commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -773,6 +773,41 @@ public void
testDeleteConnectorCreatedW
C0urante commented on code in PR #15379:
URL: https://github.com/apache/kafka/pull/15379#discussion_r1592877739
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/SingleFieldPathTest.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Fo
C0urante merged PR #15379:
URL: https://github.com/apache/kafka/pull/15379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mjsax commented on PR #15874:
URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099036837
Triggered a system test run:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder-test/20/
--
This is an automated message from the Apache Git Service.
To respond to the mes
C0urante merged PR #13801:
URL: https://github.com/apache/kafka/pull/13801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1592890872
##
metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java:
##
@@ -283,7 +283,7 @@ private static Stream
metadataVersionsForTestPartitionRegistr
gharris1727 commented on PR #15469:
URL: https://github.com/apache/kafka/pull/15469#issuecomment-2099075512
Here's the Values test coverage changes:
State | Class % | Method % | Line %
-- | -- | -- | --
Initial | 100% (4/4) | 81% (40/49) | 78% (464/589)
Added tests | 100% (4/4
gharris1727 commented on code in PR #15469:
URL: https://github.com/apache/kafka/pull/15469#discussion_r1592918790
##
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##
@@ -766,135 +852,23 @@ protected static boolean
canParseSingleTokenLiteral(Parser parser
gharris1727 commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1592924655
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -187,17 +157,25 @@ public void process(final Record record) {
gharris1727 commented on PR #15812:
URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099128163
@gongxuanzhang Do you want to merge this PR as-is, or do you want to add
more fixes to this?
--
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on PR #15601:
URL: https://github.com/apache/kafka/pull/15601#issuecomment-2099136409
Thanks Greg. If no one's had time to look at this by next week, we'll assign
a reviewer during the next Kafka Streams hangout
--
This is an automated message from the Apache Git Se
lianetm commented on code in PR #15408:
URL: https://github.com/apache/kafka/pull/15408#discussion_r1592977058
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala:
##
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
lianetm commented on code in PR #15408:
URL: https://github.com/apache/kafka/pull/15408#discussion_r1591377324
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala:
##
@@ -0,0 +1,138 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1593098515
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -106,10 +103,9 @@ public void setup() {
commitReques
jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1593105981
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3037,14 +3062,71 @@ class KafkaApisTest extends Logging {
}
@Test
- def shouldAppendToLogO
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1593116655
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -106,10 +103,9 @@ public void setup() {
commitReques
gaurav-narula opened a new pull request, #15886:
URL: https://github.com/apache/kafka/pull/15886
We observe some thread leaks in CI which point to the executor service
thread. This change tries to shutdown the executor service using the helper
method in `ThreadUtils`.
### Committer C
gaurav-narula commented on PR #15886:
URL: https://github.com/apache/kafka/pull/15886#issuecomment-2099506624
CC: @soarez @chia7712
I came across this in the [CI pipeline
run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15885/1/tests)
for #1588
chia7712 commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1593241011
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,9 +414,7 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestamp
apourchet opened a new pull request, #15887:
URL: https://github.com/apache/kafka/pull/15887
This is the first PR in a sequence to support custom task assignors in Kafka
Streams, which was described in KIP 924. It creates and exposes all of the
interfaces that will need to be implemented du
gongxuanzhang commented on PR #15812:
URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099540536
> @gongxuanzhang Do you want to merge this PR as-is, or do you want to add
more fixes to this?
I choose the latter and do more
thank you for your trust
--
This is an aut
jeqo opened a new pull request, #15888:
URL: https://github.com/apache/kafka/pull/15888
Include expiration check interval configuration as dynamic to re-schedule
producer state checker.
See commits for more details.
[KAFKA-16264]
### Committer Checklist (excluded from co
gongxuanzhang closed pull request #15812: a slight change.
URL: https://github.com/apache/kafka/pull/15812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
chia7712 commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1593260374
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,9 +414,7 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestamp
gongxuanzhang commented on PR #15812:
URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099566070
> @gongxuanzhang Do you want to merge this PR as-is, or do you want to add
more fixes to this?
I will create new pr linked
--
This is an automated message from the Apache
FrankYang0529 commented on code in PR #15868:
URL: https://github.com/apache/kafka/pull/15868#discussion_r1593273181
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java:
##
@@ -115,11 +112,11 @@ public void ensureInternalEn
gongxuanzhang commented on PR #15812:
URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099569696
@gharris1727 i request a jira acount link gongxuanzhang email:
gongxuanzhangm...@gmail.com
I need a confirmation. Can I get it from you
--
This is an automated message
emitskevich-blp opened a new pull request, #15889:
URL: https://github.com/apache/kafka/pull/15889
`Rate` metric reports value in the form of `sumOrCount`/`timePeriod`. It has
a bug in `timePeriod` calculation, which leads to spikes in result values (see
real example: `io-wait-ratio` metric
emitskevich-blp commented on code in PR #15889:
URL: https://github.com/apache/kafka/pull/15889#discussion_r1593308659
##
clients/src/test/java/org/apache/kafka/common/metrics/stats/RateTest.java:
##
@@ -64,4 +67,31 @@ public void testRateWithNoPriorAvailableSamples(int
numSamp
emitskevich-blp commented on code in PR #15889:
URL: https://github.com/apache/kafka/pull/15889#discussion_r1593310007
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -106,44 +106,55 @@ public String toString() {
public abstract doub
showuon commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1593331212
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Given a message offse
github-actions[bot] commented on PR #15337:
URL: https://github.com/apache/kafka/pull/15337#issuecomment-2099674079
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15336:
URL: https://github.com/apache/kafka/pull/15336#issuecomment-2099674110
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15332:
URL: https://github.com/apache/kafka/pull/15332#issuecomment-2099674143
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #15306:
URL: https://github.com/apache/kafka/pull/15306#issuecomment-2099674185
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
gongxuanzhang opened a new pull request, #15890:
URL: https://github.com/apache/kafka/pull/15890
@gharris1727 https://github.com/apache/kafka/pull/15812
I modified all the non-standard code according to the rules of
ModifierOrder, and I divided it into multiple commits by module for b
gongxuanzhang commented on PR #15812:
URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099682338
@gharris1727 new pr : https://github.com/apache/kafka/pull/15890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
chia7712 commented on code in PR #15872:
URL: https://github.com/apache/kafka/pull/15872#discussion_r1593354055
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -57,28 +56,47 @@
import static org.junit.jup
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593355835
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -153,15 +148,19 @@ public Map>
perBrokerOverrideProperties() {
return perBrokerOverrideProperties;
chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593356187
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -53,14 +52,15 @@ public class ClusterConfig {
private final Map adminClientProperties;
private fin
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2099697982
@m1a2st Could you please use `ConsumerGroupCommandTestUtils#generator` to
rewrite this test? thanks!
https://github.com/apache/kafka/blob/trunk/tools/src/test/java/org/apache/kafk
chia7712 commented on PR #15715:
URL: https://github.com/apache/kafka/pull/15715#issuecomment-2099699004
build get failed ... retrigger again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chia7712 commented on PR #15821:
URL: https://github.com/apache/kafka/pull/15821#issuecomment-2099700974
> This is used by ListConsumerGroupTest and DescribeConsumerGroupTest. I
think we can create a new class SimpleConsumerGroupExecutorTestUtils for it.
WDYT? Thank you.
That is addr
chia7712 commented on PR #15886:
URL: https://github.com/apache/kafka/pull/15886#issuecomment-2099705033
@gaurav-narula thanks for your fix. Before merging this PR, I want to know
which `timerTask` gets hanging when shutdown. Do you have any idea?
--
This is an automated message from th
kamalcph commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1593363337
##
core/src/main/scala/kafka/server/DelayedFetch.scala:
##
@@ -92,7 +92,10 @@ class DelayedFetch(
// has just rolled, then the high watermark offset will
chia7712 commented on code in PR #15884:
URL: https://github.com/apache/kafka/pull/15884#discussion_r1593365819
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) {
int pos = o
chia7712 merged PR #15879:
URL: https://github.com/apache/kafka/pull/15879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #15875:
URL: https://github.com/apache/kafka/pull/15875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #15875:
URL: https://github.com/apache/kafka/pull/15875#issuecomment-2099722116
@yuz10 thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chia7712 opened a new pull request, #15891:
URL: https://github.com/apache/kafka/pull/15891
thread leak where are you?
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify do
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1593390067
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cle
jeqo opened a new pull request, #15893:
URL: https://github.com/apache/kafka/pull/15893
[KAFKA-16691]
---
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documenta
kamalcph commented on PR #15825:
URL: https://github.com/apache/kafka/pull/15825#issuecomment-2099844734
> Thanks for the PR. One question: So when we temporarily set high-watermark
as ` LogOffsetMetadata(0)` for the leader, we're waiting for the high-watermark
gets updated after followers
KevinZTW commented on code in PR #15884:
URL: https://github.com/apache/kafka/pull/15884#discussion_r1593470507
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) {
int pos = o
kamalcph commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1593471183
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Given a message offs
kamalcph commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1593471183
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Given a message offs
kamalcph commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1593471183
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Given a message offs
raminqaf commented on code in PR #15601:
URL: https://github.com/apache/kafka/pull/15601#discussion_r1593500243
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -221,41 +199,28 @@ private void emitNonJoinedOuterRecords(
showuon commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1593511224
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Given a message offse
showuon commented on PR #15817:
URL: https://github.com/apache/kafka/pull/15817#issuecomment-2099912904
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon merged PR #15817:
URL: https://github.com/apache/kafka/pull/15817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on code in PR #15825:
URL: https://github.com/apache/kafka/pull/15825#discussion_r1593525765
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Given a message offse
lucasbru commented on PR #15874:
URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099949443
https://confluent-kafka-branch-builder-system-test-results-v2.s3-us-west-2.amazonaws.com/trunk/2024-05-07--001./report.html
--
This is an automated message from the Apache Git Service.
lucasbru merged PR #15874:
URL: https://github.com/apache/kafka/pull/15874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
rishiraj88 commented on code in PR #15871:
URL: https://github.com/apache/kafka/pull/15871#discussion_r1593553420
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -623,6 +623,21 @@ private void addToTasksToClose(final Map> futures,
R
cadonna merged PR #15871:
URL: https://github.com/apache/kafka/pull/15871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
chia7712 merged PR #15881:
URL: https://github.com/apache/kafka/pull/15881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
cadonna opened a new pull request, #15894:
URL: https://github.com/apache/kafka/pull/15894
Uses the new remove operation of the state updater that returns
a future to shutdown the task manager.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and impleme
showuon commented on code in PR #15884:
URL: https://github.com/apache/kafka/pull/15884#discussion_r1593636792
##
tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java:
##
@@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) {
int pos = ou
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1593668135
##
metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java:
##
@@ -283,7 +283,7 @@ private static Stream
metadataVersionsForTestPartitionRegistr
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1593670905
##
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##
@@ -717,7 +717,7 @@ public void testUnregisterBroker() throws Throwable {
601 - 700 of 71138 matches
Mail list logo
