jolshan commented on code in PR #15837:
URL: https://github.com/apache/kafka/pull/15837#discussion_r1593105981
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -3037,14 +3062,71 @@ class KafkaApisTest extends Logging {
}
@Test
- def shouldAppendToLogOnWriteTxnMarkersWhenCorrectMagicVersion(): Unit = {
+ def
shouldAppendToLogOnWriteTxnMarkersWhenCorrectMagicVersion_allowedWithAlterCluster():
Unit = {
Review Comment:
nit: we typically don't use underscores in method names like this. Can we
stick to camel case here?
Also can we parameterize this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
