junrao commented on code in PR #15621:
URL: https://github.com/apache/kafka/pull/15621#discussion_r1592859538
##########
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##########
@@ -404,9 +414,7 @@ class LogValidatorTest {
assertEquals(now + 1, validatingResults.maxTimestampMs,
s"Max timestamp should be ${now + 1}")
- val expectedOffsetOfMaxTimestamp = 1
- assertEquals(expectedOffsetOfMaxTimestamp,
validatingResults.offsetOfMaxTimestampMs,
- s"Offset of max timestamp should be 1")
+ assertEquals(2, validatingResults.shallowOffsetOfMaxTimestamp)
Review Comment:
@chia7712 : There seems to be an existing bug. The method is
`checkNonCompressed()`, but in line 370, we set the compression codec to GZIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
