chia7712 commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1593355835
##########
core/src/test/java/kafka/test/ClusterConfig.java:
##########
@@ -153,15 +148,19 @@ public Map<Integer, Map<String, String>>
perBrokerOverrideProperties() {
return perBrokerOverrideProperties;
}
- public Map<String, String> nameTags() {
- Map<String, String> tags = new LinkedHashMap<>(4);
- name().ifPresent(name -> tags.put("Name", name));
- tags.put("MetadataVersion", metadataVersion.toString());
- tags.put("Security", securityProtocol.name());
- listenerName().ifPresent(listener -> tags.put("Listener", listener));
+ public String[] tags() {
return tags;
}
+ public Map<String, String> nameTags() {
Review Comment:
My point was `Map<String, String> nameTags` should be changed to
`Set<String> nameTags` (or `displayTags`). Also, it should include the "tags".
For example:
```java
public Set<String> nameTags() {
Set<String> nameTags = new LinkedHashSet<>(tags);
nameTags.add("MetadataVersion=" + metadataVersion.toString());
nameTags.add("Security=" + securityProtocol.name());
listenerName().ifPresent(listener -> nameTags.add("Listener=" +
listener));
return nameTags;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
