ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r466052825
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java
##
@@ -0,0 +1,391 @@
+/*
+ * License
mumrah commented on pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#issuecomment-669597940
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r466063583
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##
@@ -459,6 +460,95 @@ public void sh
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r466070317
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
##
@@ -459,6 +460,95 @@ public void shouldGro
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466056481
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/EosTestDriver.java
##
@@ -379,9 +379,18 @@ private static void verifyReceivedAllRecords(fi
soarez commented on a change in pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#discussion_r466080451
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##
@@ -1865,6 +1865,17 @@ public void
shouldNotAllowNul
mjsax commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-669617981
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
soarez commented on a change in pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#discussion_r466081647
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilderTest.java
##
@@ -175,6 +177,12 @@ public void testAd
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466082144
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +61,30 @@
this.stateDirectory
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466082424
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/EosTestDriver.java
##
@@ -390,9 +399,12 @@ private static void verifyReceivedAllRec
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466082319
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -454,6 +456,41 @@ public void flush(
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466082830
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/EosTestDriver.java
##
@@ -379,9 +379,18 @@ private static void verifyReceivedAllRec
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466083086
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -461,6 +463,42 @@ public void flush(
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466084079
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java
##
@@ -38,13 +41,39 @@
*/
final class StateM
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466085153
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -344,40 +343,41 @@ public void resume() {
soarez commented on pull request #9000:
URL: https://github.com/apache/kafka/pull/9000#issuecomment-669622098
Thanks for the review @mjsax. I think I've addressed your feedback and I
have a question about whether or not we should extend this to
`ValueTransformerSupplier`.
---
junrao commented on pull request #9114:
URL: https://github.com/apache/kafka/pull/9114#issuecomment-669622211
The failed unit test seems unrelated.
@apovzner : Do you have any other comments on this? Thanks.
This is an
soarez commented on pull request #9064:
URL: https://github.com/apache/kafka/pull/9064#issuecomment-669622553
Thanks for the review @mjsax. I've addressed your feedback. Please take
another look.
This is an automated message
thomaslee commented on pull request #9111:
URL: https://github.com/apache/kafka/pull/9111#issuecomment-669624137
It's somewhat easy to do it accidentally. The scenario I was concerned about
looks something like this with auto offset commits disabled:
```java
KafkaConsumer<...> con
thomaslee edited a comment on pull request #9111:
URL: https://github.com/apache/kafka/pull/9111#issuecomment-669624137
It's somewhat easy to do it accidentally. The scenario I was concerned about
looks something like this with auto offset commits disabled:
```java
KafkaConsumer<.
chia7712 commented on a change in pull request #9102:
URL: https://github.com/apache/kafka/pull/9102#discussion_r466092016
##
File path:
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java
##
@@ -2511,4 +2511,39 @@ public void
testEnforceRebalanceTr
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466099908
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -428,53 +428,28 @@ public void resume() {
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466103277
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -428,53 +428,28 @@ public void resume() {
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466103562
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -248,12 +248,11 @@ public void handleAssignmen
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466104671
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -243,18 +242,24 @@ public void handleAssignmen
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466105496
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -267,80 +266,19 @@ public void handleAssignmen
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466107280
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -368,7 +306,102 @@ public void handleAssignmen
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466108344
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -479,24 +512,20 @@ boolean tryToCompleteRestor
ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466109545
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -248,12 +248,11 @@ public void handleAssignmen
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-669647781
@junrao I also don't want to include more mechanisms to complicate this
story. It seems to me we can do a litter factor for ```DelayedOperation``` to
resolve this issue. ```force
guozhangwang commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466113898
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -248,12 +248,11 @@ public void handleAssignmen
johnthotekat commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-669664246
> @johnthotekat Some testa are know to be flaky and we try to work on them
to avoid those build issues. It's constant effort to keep the build stable.
Will trigger a new Jenk
guozhangwang commented on pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#issuecomment-669664978
I've addressed the comments and here are the major changes:
1) do not delete checkpoint file upon loading it, and as a result simplify
the checkpointNeeded logic, initi
guozhangwang commented on a change in pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#discussion_r466134186
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -154,15 +153,15 @@ public StreamTask(final Task
abbccdda commented on a change in pull request #8923:
URL: https://github.com/apache/kafka/pull/8923#discussion_r466127053
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -646,22 +655,68 @@ private boolean isIntermediateTopic(final String topic) {
omkreddy commented on pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#issuecomment-669692997
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
apovzner commented on a change in pull request #9114:
URL: https://github.com/apache/kafka/pull/9114#discussion_r466161719
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Fou
apovzner commented on a change in pull request #9114:
URL: https://github.com/apache/kafka/pull/9114#discussion_r466162270
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Fou
kowshik commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r463912157
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4052,6 +4058,128 @@ void handleFailure(Throwable throwable)
mimaison opened a new pull request #9131:
URL: https://github.com/apache/kafka/pull/9131
Update the 3 WordCount demos to accept a configuration file. I kept the
changes to the minimum as the point of these samples is not to add a lot of
logic for parsing arguments and handling usage errors
serjchebotarev commented on pull request #9028:
URL: https://github.com/apache/kafka/pull/9028#issuecomment-669823727
@vvcephei & @mjsax this one seems to get stalled a bit - could you let me
know if anything else is to be corrected here or should we move on with
retesting the changes?
-
tombentley commented on pull request #8878:
URL: https://github.com/apache/kafka/pull/8878#issuecomment-669856151
@omkreddy any progress on this?
This is an automated message from the Apache Git Service.
To respond to the mes
omkreddy commented on pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#issuecomment-669866356
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lct45 commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r466425932
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java
##
@@ -132,16 +135,19 @@
omkreddy commented on a change in pull request #9050:
URL: https://github.com/apache/kafka/pull/9050#discussion_r466455643
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -1986,101 +1965,125 @@ private[controller] class ControllerStats extends
Ka
guillaumebort opened a new pull request #9132:
URL: https://github.com/apache/kafka/pull/9132
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
dajac commented on pull request #9114:
URL: https://github.com/apache/kafka/pull/9114#issuecomment-669977494
@junrao I have updated the KIP and posted an update to the thread in the
mailing list.
This is an automated message
stanislavkozlovski commented on pull request #9079:
URL: https://github.com/apache/kafka/pull/9079#issuecomment-669992453
@ijuma considering this is causing the system test to be flaky, is it worth
backporting? It seems like the test is present since 1.1
--
junrao merged pull request #9114:
URL: https://github.com/apache/kafka/pull/9114
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9131:
URL: https://github.com/apache/kafka/pull/9131#issuecomment-670039989
Checkstyle error:
```
> Task :streams:examples:checkstyleMain FAILED
02:46:32 [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams
hachikuji commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r466550492
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File,
* @param segments The log
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r466582281
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2982,12 +3089,33 @@ class KafkaApis(val requestChannel: RequestChannel,
mjsax commented on a change in pull request #9131:
URL: https://github.com/apache/kafka/pull/9131#discussion_r466596054
##
File path:
streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountDemo.java
##
@@ -47,18 +49,23 @@
public static final S
mjsax merged pull request #9120:
URL: https://github.com/apache/kafka/pull/9120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-670094310
Thanks for the KIP and PR @johnthotekat. Merged to `trunk`.
This is an automated message from the Apache Git Service
mjsax commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-670095558
One more thing: could you do a second PR to update the docs accordingly? We
should list the KIP at lest in `docs/streams/upgrade-guide.html` (there should
be already a section for 2
dhruvilshah3 commented on a change in pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#discussion_r466601556
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2227,13 +2210,16 @@ class Log(@volatile private var _dir: File,
* @param segments The
mjsax merged pull request #9127:
URL: https://github.com/apache/kafka/pull/9127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #9127:
URL: https://github.com/apache/kafka/pull/9127#issuecomment-670098130
Merged to `trunk` and cherry-picked to `2.6`.
This is an automated message from the Apache Git Service.
To respond t
mjsax merged pull request #9060:
URL: https://github.com/apache/kafka/pull/9060
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
junrao commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-670113688
@chia7712 : If we could solve the issue by simplifying DelayedOperation, it
would be ideal. I am not sure how your proposal avoids the above potential
deadlock. Could you provide a
hachikuji commented on pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#issuecomment-670127847
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
hachikuji commented on pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#issuecomment-670126784
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ableegoldman commented on a change in pull request #9039:
URL: https://github.com/apache/kafka/pull/9039#discussion_r466618450
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java
##
@@ -132,16 +135,19 @@
dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r466653159
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -504,6 +515,7 @@ public void onSuccess(Byt
CEikermann commented on pull request #7539:
URL: https://github.com/apache/kafka/pull/7539#issuecomment-670164657
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
CEikermann removed a comment on pull request #7539:
URL: https://github.com/apache/kafka/pull/7539#issuecomment-670164684
Would be nice to merge this
Is anything open for this merge request before it can be merged?
Thi
rondagostino commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r466681231
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable throw
dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r466653159
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -504,6 +515,7 @@ public void onSuccess(Byt
dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r466653159
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -504,6 +515,7 @@ public void onSuccess(Byt
abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r466714423
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2982,12 +3089,33 @@ class KafkaApis(val requestChannel: RequestChannel,
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466716421
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -49,6 +61,30 @@
this.stateDirectory = state
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466717212
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/EosTestDriver.java
##
@@ -379,9 +379,18 @@ private static void verifyReceivedAllRecords(fi
mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466717608
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##
@@ -344,40 +343,41 @@ public void resume() {
}
hachikuji commented on pull request #9110:
URL: https://github.com/apache/kafka/pull/9110#issuecomment-670239077
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
LMnet commented on pull request #8955:
URL: https://github.com/apache/kafka/pull/8955#issuecomment-670265314
I added `nullSerde` and rebased branch to the current trunk.
This is an automated message from the Apache Git Servic
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670281342
Hey @guozhangwang
Thanks for the review. You have some high-level questions so I'll try to
answer them here but let me know if you want to sync offline.
> the only
ableegoldman edited a comment on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670281342
Hey @guozhangwang
Thanks for the review. You have some high-level questions so I'll try to
answer them here but let me know if you want to sync offline.
edit
ableegoldman commented on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670282246
Oh I think I misread your original comment, editing my response above
This is an automated message from the A
ableegoldman edited a comment on pull request #9094:
URL: https://github.com/apache/kafka/pull/9094#issuecomment-670281342
Hey @guozhangwang
Thanks for the review. You have some high-level questions so I'll try to
answer them here but let me know if you want to sync offline.
> th
chia7712 commented on pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#issuecomment-670293057
> Could you provide a bit more detail?
The new deadlock you mentioned is caused by PR. This PR introduces extra
lock (```ReentrantLock```) to ```DelayedJoin``` (By contrast
johnthotekat opened a new pull request #9133:
URL: https://github.com/apache/kafka/pull/9133
* Added the details on KIP-648 to 2.7.0 upgrade notes -
`docs/streams/upgrade-guide.html`
@mjsax
This is an automated mess
johnthotekat commented on pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#issuecomment-670322175
@mjsax I've checked the actual documentations and just to make sure I've
also checked for the occurrence of the deprecated methods throughout the repo
and found none (except
johnthotekat commented on pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#issuecomment-670322541
@mjsax Made the changes and raised PR :
https://github.com/apache/kafka/pull/9133
Checked the actual documentations, we're good here.
--
chia7712 opened a new pull request #9134:
URL: https://github.com/apache/kafka/pull/9134
this is a bit optimization of converting producer responses. Those array
buffers need initial capacity to avoid growing continually if the request
carries a bunch of small messages and those messages a
tom1299 opened a new pull request #9135:
URL: https://github.com/apache/kafka/pull/9135
I'm a newbie to the Kafka project and going through the examples. Along the
way I did a very small refactoring to the Producer class:
* Convert the Callback class into a method
The aim was to s
tombentley commented on pull request #8878:
URL: https://github.com/apache/kafka/pull/8878#issuecomment-670404348
Thinking about, it we could avoid breaking existing links by generating both
old and new style ids: `whatever.config.name`. WDYT @mimaison @omkreddy?
-
tombentley opened a new pull request #9136:
URL: https://github.com/apache/kafka/pull/9136
See KIP-632.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tombentley commented on pull request #9136:
URL: https://github.com/apache/kafka/pull/9136#issuecomment-670438137
@omkreddy, @mimaison, @rajinisivaram, @kkonstantine, @dajac thanks for
voting on the KIP. I'd be grateful for review.
-
rajinisivaram commented on a change in pull request #9032:
URL: https://github.com/apache/kafka/pull/9032#discussion_r467052269
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4071,6 +4081,168 @@ void handleFailure(Throwable thro
jeqo opened a new pull request #9137:
URL: https://github.com/apache/kafka/pull/9137
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing stra
jeqo opened a new pull request #9138:
URL: https://github.com/apache/kafka/pull/9138
Depends on https://github.com/apache/kafka/pull/9137
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
jeqo opened a new pull request #9139:
URL: https://github.com/apache/kafka/pull/9139
Depends on https://github.com/apache/kafka/pull/9138
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
hachikuji commented on a change in pull request #7222:
URL: https://github.com/apache/kafka/pull/7222#discussion_r467139256
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java
##
@@ -406,6 +407,10 @@ synchronized void maybeSee
jeqo commented on pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#issuecomment-670601289
@ableegoldman great feedback. It makes sense to group changes in 3 different
PRs. As there is dependencies between stores, let's start with KeyValue, then
Window and finally Session
dajac opened a new pull request #9140:
URL: https://github.com/apache/kafka/pull/9140
https://github.com/apache/kafka/pull/8672 introduced a bug leading to
crashing the replica fetcher threads. The issue is that
https://github.com/apache/kafka/pull/8672 deletes the Partitions prior to
sto
jeqo closed pull request #8976:
URL: https://github.com/apache/kafka/pull/8976
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jeqo commented on pull request #8976:
URL: https://github.com/apache/kafka/pull/8976#issuecomment-670601500
Closing in favor of #9137, #9138 and #9139
This is an automated message from the Apache Git Service.
To respond to t
hachikuji commented on pull request #9140:
URL: https://github.com/apache/kafka/pull/9140#issuecomment-670606960
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on pull request #9140:
URL: https://github.com/apache/kafka/pull/9140#issuecomment-670607229
Jira: https://issues.apache.org/jira/browse/KAFKA-10374
This is an automated message from the Apache Git Service.
To
701 - 800 of 51557 matches
Mail list logo
