guozhangwang commented on pull request #8964: URL: https://github.com/apache/kafka/pull/8964#issuecomment-669664978
I've addressed the comments and here are the major changes: 1) do not delete checkpoint file upon loading it, and as a result simplify the checkpointNeeded logic, initializing the snapshotLastFlush to the loaded offsets. 2) In closing, also follow the commit -> suspend -> close ordering as in revocation / assignment. 3) If `enforceCheckpoint == true` during RUNNING, still calls maybeCheckpoint even with EOS since that is the case for suspending / closing. Newly triggered system tests are in https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4094/ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
