mjsax commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466717608
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -344,40 +343,41 @@ public void resume() {
}
/**
+ * @throws StreamsException fatal error that should cause the thread to die
+ * @throws TaskMigratedException recoverable error that would cause the
task to be removed
Review comment:
Works for me -- I am just "worried" that those comments might get
out-of-sync with the code at some point leading to bug, as we rely on the
comments when changing the caller code...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
