ableegoldman commented on a change in pull request #8964:
URL: https://github.com/apache/kafka/pull/8964#discussion_r466109545
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##########
@@ -248,12 +248,11 @@ public void handleAssignment(final Map<TaskId,
Set<TopicPartition>> activeTasks,
);
final LinkedHashMap<TaskId, RuntimeException> taskCloseExceptions =
new LinkedHashMap<>();
-
final Map<TaskId, Set<TopicPartition>> activeTasksToCreate = new
HashMap<>(activeTasks);
final Map<TaskId, Set<TopicPartition>> standbyTasksToCreate = new
HashMap<>(standbyTasks);
- final List<Task> tasksToClose = new LinkedList<>();
- final Set<Task> tasksToRecycle = new HashSet<>();
- final Set<Task> dirtyTasks = new HashSet<>();
+ final List<Task> tasksToRecycle = new LinkedList<>();
+ final List<Task> tasksToCloseClean = new LinkedList<>();
+ final List<Task> tasksToCloseDirty = new LinkedList<>();
Review comment:
Can we use an ordered set then? Just to make sure we can't end up with a
task appearing more than once in the same list/set
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
