[GitHub] [kafka] bbejeck commented on pull request #9209: Minor enhance copy array

bbejeck commented on pull request #9209: URL: https://github.com/apache/kafka/pull/9209#issuecomment-678681457 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] bbejeck commented on pull request #9208: Minor init singleton list

bbejeck commented on pull request #9208: URL: https://github.com/apache/kafka/pull/9208#issuecomment-678681564 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon

bbejeck commented on pull request #9207: URL: https://github.com/apache/kafka/pull/9207#issuecomment-678681668 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] bbejeck removed a comment on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

bbejeck removed a comment on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678681778 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678681778 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678681825 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

ijuma commented on pull request #9187: URL: https://github.com/apache/kafka/pull/9187#issuecomment-678681961 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

ijuma commented on pull request #9187: URL: https://github.com/apache/kafka/pull/9187#issuecomment-678681985 I don't think we use the inline mock maker. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on pull request #9187: MINOR: bump mockito to 3.5.0

ijuma commented on pull request #9187: URL: https://github.com/apache/kafka/pull/9187#issuecomment-678682051 Looks like 3.5.2 is the latest version https://search.maven.org/artifact/org.mockito/mockito-core/3.5.2/jar This is

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678682048 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678691061 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678722242 > Do you have any data on the improvement this achieves? I profiled (1 minute) one of servers (10 cores * 128 GB) without /without this patch. The tuple allocations is cha

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475188308 ## File path: tests/kafkatest/tests/client/quota_test.py ## @@ -162,7 +162,7 @@ def test_quota(self, quota_type, override_quota=True, producer_num=1, cons

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475188280 ## File path: tests/kafkatest/tests/streams/streams_broker_bounce_test.py ## @@ -119,7 +119,7 @@ def __init__(self, test_context): def fail_broker_typ

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475188343 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -86,14 +88,14 @@ def invoke_compatibility_program(self, features):

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475188465 ## File path: tests/kafkatest/services/verifiable_consumer.py ## @@ -386,33 +386,33 @@ def last_commit(self, tp): def total_consumed(self):

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475188558 ## File path: tests/kafkatest/services/verifiable_consumer.py ## @@ -386,33 +386,33 @@ def last_commit(self, tp): def total_consumed(self):

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475188575 ## File path: tests/kafkatest/services/verifiable_consumer.py ## @@ -386,33 +386,33 @@ def last_commit(self, tp): def total_consumed(self):

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475188599 ## File path: tests/kafkatest/services/verifiable_consumer.py ## @@ -372,7 +372,7 @@ def current_position(self, tp): def owner(self, tp): w

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475189337 ## File path: tests/kafkatest/benchmarks/core/benchmark_test.py ## @@ -88,7 +88,7 @@ def test_producer_throughput(self, acks, topic, num_producers=1, mess

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475189517 ## File path: tests/kafkatest/tests/connect/connect_distributed_test.py ## @@ -420,11 +421,14 @@ def test_bounce(self, clean, connect_protocol):

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475189547 ## File path: tests/kafkatest/tests/end_to_end.py ## @@ -87,7 +85,7 @@ def on_record_consumed(self, record, node): def await_consumed_offsets(self,

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475192155 ## File path: tests/kafkatest/version.py ## @@ -49,6 +49,34 @@ def __str__(self): else: return LooseVersion.__str__(self) +def

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475192316 ## File path: tests/kafkatest/version.py ## @@ -49,6 +49,34 @@ def __str__(self): else: return LooseVersion.__str__(self) +def

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475192484 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -86,14 +88,14 @@ def invoke_compatibility_program(self, features):

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475192572 ## File path: tests/kafkatest/services/performance/producer_performance.py ## @@ -78,7 +78,7 @@ def start_cmd(self, node): 'bootstrap_servers'

[GitHub] [kafka] nizhikov commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

nizhikov commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475192532 ## File path: tests/kafkatest/tests/connect/connect_distributed_test.py ## @@ -420,11 +421,14 @@ def test_bounce(self, clean, connect_protocol):

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475195007 ## File path: tests/kafkatest/tests/connect/connect_distributed_test.py ## @@ -440,11 +441,11 @@ def test_bounce(self, clean, connect_protocol):

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475194696 ## File path: tests/kafkatest/services/performance/producer_performance.py ## @@ -78,7 +78,7 @@ def start_cmd(self, node): 'bootstrap_servers

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475195929 ## File path: tests/kafkatest/services/verifiable_consumer.py ## @@ -386,33 +386,33 @@ def last_commit(self, tp): def total_consumed(self):

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475195007 ## File path: tests/kafkatest/tests/connect/connect_distributed_test.py ## @@ -440,11 +441,11 @@ def test_bounce(self, clean, connect_protocol):

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475196152 ## File path: tests/kafkatest/tests/verifiable_consumer_test.py ## @@ -40,7 +40,7 @@ def _all_partitions(self, topic, num_partitions): def _partiti

[GitHub] [kafka] JoelWee commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

JoelWee commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475196944 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init(fina

[GitHub] [kafka] chia7712 commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

chia7712 commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-678753750 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] JoelWee commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

JoelWee commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475198868 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init(fina

[GitHub] [kafka] ivandasch commented on a change in pull request #9196: [WIP] KAFKA-10402: Upgrade system tests to python3

ivandasch commented on a change in pull request #9196: URL: https://github.com/apache/kafka/pull/9196#discussion_r475227190 ## File path: tests/kafkatest/utils/__init__.py ## @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations

[GitHub] [kafka] inponomarev opened a new pull request #9210: KAFKA-10369 [WIP] KIP-655 implementation

inponomarev opened a new pull request #9210: URL: https://github.com/apache/kafka/pull/9210 This is an incomplete, proof-of-concept implementation of [KIP-655](https://cwiki.apache.org/confluence/display/KAFKA/KIP-655:+Windowed+Distinct+Operation+for+Kafka+Streams+API) for the sake of disc

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-678834247 @bbejeck One question: As part of my PR, I add a new test for DefaultMessageFormatter class: core/src/test/scala/kafka/tools/DefaultMessageFormatterTest.scala

[GitHub] [kafka] chia7712 commented on pull request #9134: MINOR: set initial capacity for all array buffers in converting produ…

chia7712 commented on pull request #9134: URL: https://github.com/apache/kafka/pull/9134#issuecomment-678894285 test this patch with timed profiling recording (5 minutes) and the memory usage of array reallocation is reduced from 3.14 GB to 2.81 GB

[GitHub] [kafka] showuon commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

showuon commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r475352582 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1401,16 +1401,17 @@ object GroupMetadataManager { val ve

[GitHub] [kafka] showuon edited a comment on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

showuon edited a comment on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-678914354 @ijuma , thanks for your comments. I've updated in this commit: https://github.com/apache/kafka/pull/9202/commits/ae5ae323f159afc9bb384252e45bef640531ea94. I also added one

[GitHub] [kafka] showuon commented on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

showuon commented on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-678914354 @ijuma , thanks for your comments. I've updated in this commit: https://github.com/apache/kafka/pull/9202/commits/ae5ae323f159afc9bb384252e45bef640531ea94. I'm also adding one mor

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475358692 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/OffsetCheckpointTest.java ## @@ -135,6 +136,20 @@ public void shouldThrowOnInv

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475362316 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475362316 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475362316 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-678959902 @mjsax , I've updated in this commit: https://github.com/apache/kafka/pull/9121/commits/b248ccc4f35ce6bb7ef865c65392710c1558ca20. Thanks. ---

[GitHub] [kafka] showuon edited a comment on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon edited a comment on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-678959902 @mjsax , I've updated in this commit: https://github.com/apache/kafka/pull/9121/commits/12d3826a87a5b21033e2f81c6a486353e79d8591. Thanks.

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] showuon commented on a change in pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on a change in pull request #9121: URL: https://github.com/apache/kafka/pull/9121#discussion_r475393747 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImplTest.java ## @@ -180,6 +183,27 @@ public void should

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475627290 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -141,7 +142,8 @@ object Partition extends KafkaMetricsGroup { stateStore = zkIsr

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475629593 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -635,7 +666,7 @@ class Partition(val topicPartition: TopicPartition, // chec

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475630695 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -806,8 +840,9 @@ class Partition(val topicPartition: TopicPartition, // avoid un

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475625111 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -325,7 +326,8 @@ UNSTABLE_OFFSET_COMMIT(88, "There are unstable o

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475632719 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1257,4 +1364,4 @@ class Partition(val topicPartition: TopicPartition, } part

[GitHub] [kafka] xakassi opened a new pull request #9211: KAFKA-10426: Deadlock on session key update.

xakassi opened a new pull request #9211: URL: https://github.com/apache/kafka/pull/9211 DistributedHerder goes to updateConfigsWithIncrementalCooperative() synchronized method and called configBackingStore.snapshot() which take a lock on internal object in KafkaConfigBackingStore class.

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r475626573 ## File path: config/log4j.properties ## @@ -61,8 +61,8 @@ log4j.appender.authorizerAppender.layout.ConversionPattern=[%d] %p %m (%c)%n log4j.logger.org.ap

[GitHub] [kafka] cmccabe commented on pull request #9194: KAFKA-10384: Separate converters from generated messages

cmccabe commented on pull request #9194: URL: https://github.com/apache/kafka/pull/9194#issuecomment-679187796 > Ok, just to make sure I understand [...] Now for a given schema, we will generate SomeMessageData as well as SomeMessageJsonConverter Right, you got it.

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475695750 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475696554 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475698813 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on pull request #9032: URL: https://github.com/apache/kafka/pull/9032#issuecomment-679199653 @rajinisivaram : I'd like to understand your suggestion to forbid authenticating via delegation token here. It doesn't seem consistent with how we handle delegation tokens in gen

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475710400 ## File path: clients/src/main/java/org/apache/kafka/common/errors/BrokerAuthorizationFailureException.java ## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475712573 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java ## @@ -325,7 +326,9 @@ UNSTABLE_OFFSET_COMMIT(88, "There are unstable

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475714230 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AlterConfigsRequest.java ## @@ -87,6 +87,16 @@ public Builder(Map configs, boolean va

[GitHub] [kafka] cmccabe commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

cmccabe commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r475725389 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -316,7 +316,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SYSTE

[GitHub] [kafka] chia7712 opened a new pull request #9212: MINOR: don't keep reference of receive buffer when the value of head …

chia7712 opened a new pull request #9212: URL: https://github.com/apache/kafka/pull/9212 Users, who try to avoid null variable, can replace null by empty array to build header to be a kind of "flag". The ```RecordHeader#value()``` may be never called (as users only want to check existence

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475750058 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[GitHub] [kafka] lbradstreet opened a new pull request #9213: MINOR: add epoch lineage checks to system tests

lbradstreet opened a new pull request #9213: URL: https://github.com/apache/kafka/pull/9213 This adds assertions to check that leader epoch lineages match between replicas. These have been added to system tests that involve broker restarts and that wait for replicas to rejoin the ISR b

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475756645 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[GitHub] [kafka] rajinisivaram commented on pull request #9200: MINOR: mirror integration tests should not call System.exit

rajinisivaram commented on pull request #9200: URL: https://github.com/apache/kafka/pull/9200#issuecomment-679249066 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-679256967 @chia7712 : Sorry for the late response. I just realized there seems to be another issue in addition to the above one that I mentioned. The second issue is that we hold a group loc

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475771230 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r475771230 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to th

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-679258872 > I should just delete the test for DefaultMessageFormatter in ConsoleConsumerTest.scala. @badaiaqrandista I'm not sure. My vote would be to keep the test but move i

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475791126 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475792745 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[GitHub] [kafka] guozhangwang commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

guozhangwang commented on a change in pull request #9156: URL: https://github.com/apache/kafka/pull/9156#discussion_r475792671 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFil

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r475800482 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,29 +60,46 @@ public void init

[GitHub] [kafka] hachikuji merged pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

hachikuji merged pull request #9112: URL: https://github.com/apache/kafka/pull/9112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei opened a new pull request #9214: [DO NOT MERGE] POC: unify all jvm cache pools

vvcephei opened a new pull request #9214: URL: https://github.com/apache/kafka/pull/9214 Currently, users of Suppress in strict mode must either not configure a memory bound or consider a per-operator, per-partition bound. The former would result in the application crashing ungracefully if

[GitHub] [kafka] mjsax commented on pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

mjsax commented on pull request #9174: URL: https://github.com/apache/kafka/pull/9174#issuecomment-679347362 Might it be worth to cherry-pick to `2.6` ? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ableegoldman commented on pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

ableegoldman commented on pull request #9174: URL: https://github.com/apache/kafka/pull/9174#issuecomment-679373369 @mjsax Be my guest 🙂 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] ning2008wisc opened a new pull request #9215: KAFKA-10133: MM2 readme update on config

ning2008wisc opened a new pull request #9215: URL: https://github.com/apache/kafka/pull/9215 Per https://issues.apache.org/jira/browse/KAFKA-10133, MM2 users sometimes confuse on specifying or overriding the default configurations at different levels: connector, MM2, producer/consumers. It

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r475919413 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -0,0 +1,690 @@ +/* + * Lic

[GitHub] [kafka] ableegoldman commented on pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on pull request #9039: URL: https://github.com/apache/kafka/pull/9039#issuecomment-679394512 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-679398619 @bbejeck It failed because it print the partition number as a single integer after the value. I moved the partition to be before the key (if printed) and value, an

[GitHub] [kafka] ableegoldman commented on pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

ableegoldman commented on pull request #9094: URL: https://github.com/apache/kafka/pull/9094#issuecomment-679399444 @guozhangwang can we finally merge this? 🙂 This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] guozhangwang commented on pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

guozhangwang commented on pull request #9094: URL: https://github.com/apache/kafka/pull/9094#issuecomment-679408267 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] guozhangwang commented on pull request #8834: MINOR: Do not disable heartbeat during Rebalance

guozhangwang commented on pull request #8834: URL: https://github.com/apache/kafka/pull/8834#issuecomment-679419336 @ableegoldman I'm re-targeting this against https://issues.apache.org/jira/browse/KAFKA-10134 now as I found the root cause of that ticket is actually because we do not send

[GitHub] [kafka] ning2008wisc commented on pull request #9215: KAFKA-10133: MM2 readme update on config

ning2008wisc commented on pull request #9215: URL: https://github.com/apache/kafka/pull/9215#issuecomment-679420821 Hi @ryannedolan @mimaison just in case I could borrow few minutes from you to take a quick review. Thanks T

[GitHub] [kafka] jthompson6 opened a new pull request #9216: KAFKA-10428: Fix schema for header conversion in MirrorSourceTask.

jthompson6 opened a new pull request #9216: URL: https://github.com/apache/kafka/pull/9216 The addBytes method adds the header using Schema.BYTES, which results in base64 encoding when the record is stored. SimpleHeaderConverter#toConnectHeader implements schema inference which we can us

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r475985073 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -328,6 +328,68 @@ public v

[GitHub] [kafka] jeqo commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

jeqo commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r475910689 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -119,15 +118,16 @@ * * This iterator must be closed afte

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r475999351 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java ## @@ -419,13 +504,13 @@ Long minTime() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476001166 ## File path: streams/src/main/java/org/apache/kafka/streams/state/WindowStore.java ## @@ -119,15 +118,16 @@ * * This iterator must be clo

[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

ableegoldman commented on a change in pull request #9138: URL: https://github.com/apache/kafka/pull/9138#discussion_r476003479 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryWindowStore.java ## @@ -163,7 +164,17 @@ public void put(final By

[GitHub] [kafka] guozhangwang merged pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

guozhangwang merged pull request #9094: URL: https://github.com/apache/kafka/pull/9094 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

<    11   12   13   14   15   16   17   18   19   20   >