badaiaqrandista commented on pull request #9099:
URL: https://github.com/apache/kafka/pull/9099#issuecomment-678834247


   @bbejeck 
   
   One question: As part of my PR, I add a new test for DefaultMessageFormatter 
class: core/src/test/scala/kafka/tools/DefaultMessageFormatterTest.scala
   
   But I found that there is another unit test that include a test for 
DefaultMessageFormatter class:
   
https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala#L501
   
   This was the cause of the system test failure yesterday. I changed the 
latter test to work with the updated DefaultMessageFormatter. But after 
thinking about it further, I should just delete the test for 
DefaultMessageFormatter in ConsoleConsumerTest.scala.
   
   What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to