nizhikov commented on a change in pull request #9196:
URL: https://github.com/apache/kafka/pull/9196#discussion_r475189337
##########
File path: tests/kafkatest/benchmarks/core/benchmark_test.py
##########
@@ -88,7 +88,7 @@ def test_producer_throughput(self, acks, topic,
num_producers=1, message_size=DE
self.validate_versions(client_version, broker_version)
self.start_kafka(security_protocol, security_protocol, broker_version,
tls_version)
# Always generate the same total amount of data
- nrecords = int(self.target_data_size / message_size)
+ nrecords = int(self.target_data_size // message_size)
Review comment:
fixed.
##########
File path: tests/kafkatest/services/monitor/http.py
##########
@@ -114,7 +114,7 @@ def metrics(self, host=None, client_id=None, name=None,
group=None, tags=None):
Get any collected metrics that match the specified parameters,
yielding each as a tuple of
(key, [<timestamp, value>, ...]) values.
"""
- for k, values in self._http_metrics.iteritems():
+ for k, values in iter(self._http_metrics.items()):
Review comment:
fixed.
##########
File path: tests/kafkatest/services/monitor/http.py
##########
@@ -154,7 +154,7 @@ def do_POST(self):
name = raw_metric['name']
group = raw_metric['group']
# Convert to tuple of pairs because dicts & lists are unhashable
- tags = tuple([(k, v) for k, v in raw_metric['tags'].iteritems()]),
+ tags = tuple([(k, v) for k, v in
iter(raw_metric['tags'].items())]),
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
